Btrfs: remove no longer used 'sync' member from transaction handle
diff mbox series

Message ID 20190311131056.2365-1-fdmanana@kernel.org
State New
Headers show
Series
  • Btrfs: remove no longer used 'sync' member from transaction handle
Related show

Commit Message

Filipe Manana March 11, 2019, 1:10 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Commit db2462a6ad3d ("btrfs: don't run delayed refs in the end transaction
logic") removed its last use, so now it does absolutely nothing, therefore
remove it.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 fs/btrfs/extent-tree.c | 6 ------
 fs/btrfs/file.c        | 1 -
 fs/btrfs/transaction.h | 1 -
 3 files changed, 8 deletions(-)

Comments

Nikolay Borisov March 11, 2019, 1:13 p.m. UTC | #1
On 11.03.19 г. 15:10 ч., fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Commit db2462a6ad3d ("btrfs: don't run delayed refs in the end transaction
> logic") removed its last use, so now it does absolutely nothing, therefore
> remove it.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/extent-tree.c | 6 ------
>  fs/btrfs/file.c        | 1 -
>  fs/btrfs/transaction.h | 1 -
>  3 files changed, 8 deletions(-)
> 
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 994f0cc41799..bda83087271f 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -2910,12 +2910,6 @@ static void delayed_ref_async_start(struct btrfs_work *work)
>  		goto done;
>  	}
>  
> -	/*
> -	 * trans->sync means that when we call end_transaction, we won't
> -	 * wait on delayed refs
> -	 */
> -	trans->sync = true;
> -
>  	/* Don't bother flushing if we got into a different transaction */
>  	if (trans->transid > async->transid)
>  		goto end;
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index 34fe8a58b0e9..94c1c86fd18a 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -2165,7 +2165,6 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
>  		inode_unlock(inode);
>  		goto out;
>  	}
> -	trans->sync = true;
>  
>  	ret = btrfs_log_dentry_safe(trans, dentry, start, end, &ctx);
>  	if (ret < 0) {
> diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
> index f1ba78949d1b..b34678e7968e 100644
> --- a/fs/btrfs/transaction.h
> +++ b/fs/btrfs/transaction.h
> @@ -120,7 +120,6 @@ struct btrfs_trans_handle {
>  	bool allocating_chunk;
>  	bool can_flush_pending_bgs;
>  	bool reloc_reserved;
> -	bool sync;
>  	bool dirty;
>  	struct btrfs_root *root;
>  	struct btrfs_fs_info *fs_info;
>
David Sterba March 11, 2019, 2:38 p.m. UTC | #2
On Mon, Mar 11, 2019 at 01:10:56PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Commit db2462a6ad3d ("btrfs: don't run delayed refs in the end transaction
> logic") removed its last use, so now it does absolutely nothing, therefore
> remove it.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Added to misc-5.2, thanks.

Patch
diff mbox series

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 994f0cc41799..bda83087271f 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -2910,12 +2910,6 @@  static void delayed_ref_async_start(struct btrfs_work *work)
 		goto done;
 	}
 
-	/*
-	 * trans->sync means that when we call end_transaction, we won't
-	 * wait on delayed refs
-	 */
-	trans->sync = true;
-
 	/* Don't bother flushing if we got into a different transaction */
 	if (trans->transid > async->transid)
 		goto end;
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 34fe8a58b0e9..94c1c86fd18a 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -2165,7 +2165,6 @@  int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
 		inode_unlock(inode);
 		goto out;
 	}
-	trans->sync = true;
 
 	ret = btrfs_log_dentry_safe(trans, dentry, start, end, &ctx);
 	if (ret < 0) {
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
index f1ba78949d1b..b34678e7968e 100644
--- a/fs/btrfs/transaction.h
+++ b/fs/btrfs/transaction.h
@@ -120,7 +120,6 @@  struct btrfs_trans_handle {
 	bool allocating_chunk;
 	bool can_flush_pending_bgs;
 	bool reloc_reserved;
-	bool sync;
 	bool dirty;
 	struct btrfs_root *root;
 	struct btrfs_fs_info *fs_info;