[32/32] lustre: mgc: remove llog_process_lock
diff mbox series

Message ID 155252231224.26912.7309623617839627723.stgit@noble.brown
State New
Headers show
Series
  • Another bunch of lustre patches.
Related show

Commit Message

NeilBrown March 14, 2019, 12:11 a.m. UTC
This mutex is never used, so remove it.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/staging/lustre/lustre/mgc/mgc_request.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Andreas Dilger April 3, 2019, 8:47 p.m. UTC | #1
On Mar 13, 2019, at 18:11, NeilBrown <neilb@suse.com> wrote:
> 
> This mutex is never used, so remove it.
> 
> Signed-off-by: NeilBrown <neilb@suse.com>

Reviewed-by: Andreas Dilger <adilger@whamcloud.com>

> ---
> drivers/staging/lustre/lustre/mgc/mgc_request.c |    6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index a805705f357e..b2b20b41ed25 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -383,8 +383,6 @@ config_log_add(struct obd_device *obd, char *logname,
> 	return ERR_PTR(rc);
> }
> 
> -static DEFINE_MUTEX(llog_process_lock);
> -
> static inline void config_mark_cld_stop(struct config_llog_data *cld)
> {
> 	if (!cld)
> @@ -1535,9 +1533,7 @@ static int mgc_process_cfg_log(struct obd_device *mgc,
> 	__llog_ctxt_put(env, ctxt);
> 
> 	/*
> -	 * update settings on existing OBDs. doing it inside
> -	 * of llog_process_lock so no device is attaching/detaching
> -	 * in parallel.
> +	 * update settings on existing OBDs.
> 	 * the logname must be <fsname>-sptlrpc
> 	 */
> 	if (sptlrpc_started) {
> 
> 

Cheers, Andreas
---
Andreas Dilger
Principal Lustre Architect
Whamcloud

Patch
diff mbox series

diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index a805705f357e..b2b20b41ed25 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -383,8 +383,6 @@  config_log_add(struct obd_device *obd, char *logname,
 	return ERR_PTR(rc);
 }
 
-static DEFINE_MUTEX(llog_process_lock);
-
 static inline void config_mark_cld_stop(struct config_llog_data *cld)
 {
 	if (!cld)
@@ -1535,9 +1533,7 @@  static int mgc_process_cfg_log(struct obd_device *mgc,
 	__llog_ctxt_put(env, ctxt);
 
 	/*
-	 * update settings on existing OBDs. doing it inside
-	 * of llog_process_lock so no device is attaching/detaching
-	 * in parallel.
+	 * update settings on existing OBDs.
 	 * the logname must be <fsname>-sptlrpc
 	 */
 	if (sptlrpc_started) {