[09.5/36] xfs_io: document fzero_f -k option in manpage
diff mbox series

Message ID 9784a4eb-f90c-c57a-34af-0039e24e9e78@redhat.com
State Accepted
Headers show
Series
  • Untitled series #91905
Related show

Commit Message

Eric Sandeen March 15, 2019, 12:25 a.m. UTC
Perhaps the reason -k was broken is that nobody knew it existed?

Fixes: 938904c4 ("xfs_io: add fzero command for zeroing range via fallocate")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Darrick J. Wong March 15, 2019, 12:31 a.m. UTC | #1
On Thu, Mar 14, 2019 at 07:25:28PM -0500, Eric Sandeen wrote:
> Perhaps the reason -k was broken is that nobody knew it existed?
> 
> Fixes: 938904c4 ("xfs_io: add fzero command for zeroing range via fallocate")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index fbf50df..980dcfd 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -516,10 +516,13 @@ Call fallocate with FALLOC_FL_UNSHARE_RANGE flag as described in the
>  .BR fallocate (2)
>  manual page to unshare all shared blocks within the range.
>  .TP
> -.BI fzero " offset length"
> +.BI "fzero [ \-k ]" " offset length"
>  Call fallocate with FALLOC_FL_ZERO_RANGE flag as described in the
>  .BR fallocate (2)
>  manual page to allocate and zero blocks within the range.
> +With the
> +.B -k
> +option, use the FALLOC_FL_KEEP_SIZE flag as well.
>  .TP
>  .BI zero " offset length"
>  Call xfsctl with
>

Patch
diff mbox series

diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
index fbf50df..980dcfd 100644
--- a/man/man8/xfs_io.8
+++ b/man/man8/xfs_io.8
@@ -516,10 +516,13 @@  Call fallocate with FALLOC_FL_UNSHARE_RANGE flag as described in the
 .BR fallocate (2)
 manual page to unshare all shared blocks within the range.
 .TP
-.BI fzero " offset length"
+.BI "fzero [ \-k ]" " offset length"
 Call fallocate with FALLOC_FL_ZERO_RANGE flag as described in the
 .BR fallocate (2)
 manual page to allocate and zero blocks within the range.
+With the
+.B -k
+option, use the FALLOC_FL_KEEP_SIZE flag as well.
 .TP
 .BI zero " offset length"
 Call xfsctl with