From patchwork Fri Mar 15 09:51:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 10854393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AAA131515 for ; Fri, 15 Mar 2019 09:54:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B31E2886E for ; Fri, 15 Mar 2019 09:54:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A6B62A79C; Fri, 15 Mar 2019 09:54:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 61EF92886E for ; Fri, 15 Mar 2019 09:54:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0CBA184E; Fri, 15 Mar 2019 10:53:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0CBA184E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1552643679; bh=J4UIxWI/EiJiybZmcIu/FiiFuHHM4VrSrofpW3+KoXQ=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Kgxdg/EC4OYIUeuyPRK4jaXdmxw+hLpZT+Rh0RnoEMbmZxRetqZncyDl9BeA1YF/z Om6nHFYfzx5yud0jiQLn1VQHJzzJE+aEzrTiVTn0ZBS4A8A9a/9bUJ7OUcmy2sF6Tj xoKw8Rpze9oFJTo0yOiX9JntOMgvP2WikpwN83HA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 56F32F896F3; Fri, 15 Mar 2019 10:53:48 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 633D8F89701; Fri, 15 Mar 2019 10:53:46 +0100 (CET) Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9B532F89673 for ; Fri, 15 Mar 2019 10:53:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9B532F89673 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=endlessm-com.20150623.gappssmtp.com header.i=@endlessm-com.20150623.gappssmtp.com header.b="g+pg/yXW" Received: by mail-pf1-x444.google.com with SMTP id v64so5987288pfb.1 for ; Fri, 15 Mar 2019 02:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R34Hc5VrGY8X4eTOWGoukKjOWMd10HDmULGs/URQgL8=; b=g+pg/yXW7qV5PSTm7QTFnDApsNiqFWNMAP75cmNjzVnveo/6kzujpuK0ah5SEcQFyT HyRyksm84LQIG3nOQNw0stSZB6kXgd9+bcYpTttB8xcK2AdFWETZRbGqvwKy1ZkFFzw5 Jxd1k+CJ1UYx7HIrC9NcQR+zqnYTJeZit+xhZkHSrEHV15m32VY6pnMMy7jM5bd+NPbS cQ2/uuSPAn3wz0A5X5PTZPA+osB3UZ1q1r/0zdGz+TtEqbrnlcWNTlz+Zg/TtaPerocE TMvbgj26MGtgLVBGqK9XCBdhtbyyYBQdhAUiYZs4MdC8OXOUmOPUgbO+y1D1pji4+DP6 Z47A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R34Hc5VrGY8X4eTOWGoukKjOWMd10HDmULGs/URQgL8=; b=C9hmLgjcisI+NaHEWHr7KY7NAQj+buP4jvdVMmaVtebf2FQUnN4oWI+a7fN9qV8iVp VCeHctsH4hX3t+iRNHtMq/cWkUof9I07KaNJbPX3HA/J0B8zSJN+GD9uy3SjGimPPbEn WoPyIAvsx2HemR+rlx+kDqjyidendjAORF5Wk6j76jxsgGbBVbLCp5PaPKU/cmx/kKs2 cd9vTgMCq430xbBLMslknTC4YUoPCLPt23uPescBu6LDe8P81ZmStjHJ/3VSTWBHQ+b4 39xreYQr7cF3yIdKKGqiDpJUErCC9HmqaJV2VG+b+oVNYW3MilZM7du+oQ85cLusvTZO Yv/Q== X-Gm-Message-State: APjAAAVQI2ZkBpTxDVWitk7xxIXz9VNTMcFad/JdN25ssgJIaOQ6Di4T j766iB0TcKGkDKwRalX/8klgIQ== X-Google-Smtp-Source: APXvYqwQ4PdExfkqBUDETtnV/7xg7siqZb27NlcmkwAMbb4F+M8bkTmUgT+fpu66g2xw5OnmIBwypA== X-Received: by 2002:a17:902:694b:: with SMTP id k11mr3298306plt.288.1552643620759; Fri, 15 Mar 2019 02:53:40 -0700 (PDT) Received: from localhost.localdomain (123-204-46-122.static.seed.net.tw. [123.204.46.122]) by smtp.gmail.com with ESMTPSA id l28sm4439705pfi.186.2019.03.15.02.53.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 02:53:40 -0700 (PDT) From: Jian-Hong Pan To: Takashi Iwai , Kailang Yang Date: Fri, 15 Mar 2019 17:51:09 +0800 Message-Id: <20190315095108.9195-1-jian-hong@endlessm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Cc: Jian-Hong Pan , alsa-devel@alsa-project.org, linux@endlessm.com, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH v2] ALSA: hda/realtek: Enable headset MIC of Acer AIO with ALC286 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP Some Acer AIO desktops like Veriton Z6860G, Z4860G and Z4660G cannot record sound from headset MIC. This patch adds the ALC286_FIXUP_ACER_AIO_HEADSET_MIC quirk to fix this issue. Signed-off-by: Jian-Hong Pan --- v2: According to Realtek's suggestion, change the COEF 0x4f from 0xd429 to 0x5029. Thanks to Realtek! sound/pci/hda/patch_realtek.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 384719d5c44e..191830d4fa40 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5687,6 +5687,7 @@ enum { ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE, ALC225_FIXUP_WYSE_AUTO_MUTE, ALC225_FIXUP_WYSE_DISABLE_MIC_VREF, + ALC286_FIXUP_ACER_AIO_HEADSET_MIC, }; static const struct hda_fixup alc269_fixups[] = { @@ -6685,6 +6686,16 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC }, + [ALC286_FIXUP_ACER_AIO_HEADSET_MIC] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + { 0x20, AC_VERB_SET_COEF_INDEX, 0x4f }, + { 0x20, AC_VERB_SET_PROC_COEF, 0x5029 }, + { } + }, + .chained = true, + .chain_id = ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6701,9 +6712,9 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS), SND_PCI_QUIRK(0x1025, 0x102b, "Acer Aspire C24-860", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14", ALC283_FIXUP_CHROME_BOOK), - SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), - SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), - SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), + SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), + SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS),