| Message ID | 20190315162503.131510-1-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "modsign: Abort modules_install when signing fails" | expand |
On Sat, Mar 16, 2019 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote: > > This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. > > The commit was fine but is no longer needed as of commit 3a2429e1faf4 > ("kbuild: change if_changed_rule for multi-line recipe"). Let's go > back to using ";" to be consistent. > > For some discussion, see: > > https://lkml.kernel.org/r/CAK7LNASde0Q9S5GKeQiWhArfER4S4wL1=R_FW8q0++_X3T5=hQ@mail.gmail.com > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Applied to linux-kbuild. Thanks. > scripts/Makefile.modinst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst > index ff5ca9817a85..0dae402661f3 100644 > --- a/scripts/Makefile.modinst > +++ b/scripts/Makefile.modinst > @@ -23,7 +23,7 @@ quiet_cmd_modules_install = INSTALL $@ > mkdir -p $(2) ; \ > cp $@ $(2) ; \ > $(mod_strip_cmd) $(2)/$(notdir $@) ; \ > - $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) && \ > + $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) ; \ > $(mod_compress_cmd) $(2)/$(notdir $@) > > # Modules built outside the kernel source tree go into extra by default > -- > 2.21.0.360.g471c308f928-goog >
diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index ff5ca9817a85..0dae402661f3 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -23,7 +23,7 @@ quiet_cmd_modules_install = INSTALL $@ mkdir -p $(2) ; \ cp $@ $(2) ; \ $(mod_strip_cmd) $(2)/$(notdir $@) ; \ - $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) && \ + $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) ; \ $(mod_compress_cmd) $(2)/$(notdir $@) # Modules built outside the kernel source tree go into extra by default
This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. The commit was fine but is no longer needed as of commit 3a2429e1faf4 ("kbuild: change if_changed_rule for multi-line recipe"). Let's go back to using ";" to be consistent. For some discussion, see: https://lkml.kernel.org/r/CAK7LNASde0Q9S5GKeQiWhArfER4S4wL1=R_FW8q0++_X3T5=hQ@mail.gmail.com Signed-off-by: Douglas Anderson <dianders@chromium.org> --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)