diff mbox series

[4/5] Android: avoid link_warning

Message ID 20190315091706.26772-5-cwhuang@linux.org.tw (mailing list archive)
State New, archived
Headers show
Series [1/5] Android: avoid using versionsort | expand

Commit Message

Chih-Wei Huang March 15, 2019, 9:17 a.m. UTC
It will be treated as an error.

Signed-off-by: Chih-Wei Huang <cwhuang@linux.org.tw>
---
 src/pcm/pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chih-Wei Huang March 15, 2019, 4:19 p.m. UTC | #1
Jaroslav Kysela <perex@perex.cz> 於 2019年3月15日 週五 下午8:18寫道:
>
> Dne 15. 03. 19 v 10:17 Chih-Wei Huang napsal(a):
> > It will be treated as an error.
> >
> > Signed-off-by: Chih-Wei Huang <cwhuang@linux.org.tw>
> > ---
> >  src/pcm/pcm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c
> > index 11aec805..4bb5fe5f 100644
> > --- a/src/pcm/pcm.c
> > +++ b/src/pcm/pcm.c
> > @@ -1053,7 +1053,7 @@ int snd_pcm_hwsync(snd_pcm_t *pcm)
> >       snd_pcm_unlock(pcm);
> >       return err;
> >  }
> > -#ifndef DOC_HIDDEN
> > +#if !defined(DOC_HIDDEN) && !defined(ANDROID)
> >  link_warning(snd_pcm_hwsync, "Warning: snd_pcm_hwsync() is deprecated, consider to use snd_pcm_avail()");
> >  #endif
>
> Create a new option in the configure script (--disable-hwsync-warning or
> so). I don't think that this should be Android only specific case.

I'm sorry but Android doesn't use the configure script.
The Android build system include the Android.mk in
the subfolders and build the targets defined in it directly.

I've tried to add cflag -DDOC_HIDDEN to Android.mk but
it generates more errors.

If change it to

#if !defined(DOC_HIDDEN) && !defined(NO_HWSYNC_WARNING)

and then define NO_HWSYNC_WARNING in Android.mk,
is it acceptable?
diff mbox series

Patch

diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c
index 11aec805..4bb5fe5f 100644
--- a/src/pcm/pcm.c
+++ b/src/pcm/pcm.c
@@ -1053,7 +1053,7 @@  int snd_pcm_hwsync(snd_pcm_t *pcm)
 	snd_pcm_unlock(pcm);
 	return err;
 }
-#ifndef DOC_HIDDEN
+#if !defined(DOC_HIDDEN) && !defined(ANDROID)
 link_warning(snd_pcm_hwsync, "Warning: snd_pcm_hwsync() is deprecated, consider to use snd_pcm_avail()");
 #endif