diff mbox series

[5/5] mac80211_hwsim: Ext Key ID support (NATIVE)

Message ID 20190316204208.16497-6-alexander@wetzel-home.de (mailing list archive)
State Superseded
Delegated to: Johannes Berg
Headers show
Series Extended Key ID support | expand

Commit Message

Alexander Wetzel March 16, 2019, 8:42 p.m. UTC
Driver is not supporting hardware encryption and therefore fully
compatible with Extended Key ID.

Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de>
---
 drivers/net/wireless/mac80211_hwsim.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Johannes Berg March 17, 2019, 10:38 p.m. UTC | #1
Since I'm travelling to netdev and all, I'm not sure I'll actually get
around to this patchset soon.

On Sat, 2019-03-16 at 21:42 +0100, Alexander Wetzel wrote:
> Driver is not supporting hardware encryption and therefore fully
> compatible with Extended Key ID.

On this particular patch now reading this I'm wondering if we shouldn't
just do that in mac80211 if there's no set_key callback? I suspect
that'd affect a few drivers that are otherwise more or less orphaned.

johannes
Alexander Wetzel March 19, 2019, 8:44 p.m. UTC | #2
>> Driver is not supporting hardware encryption and therefore fully
>> compatible with Extended Key ID.
> 
> On this particular patch now reading this I'm wondering if we shouldn't
> just do that in mac80211 if there's no set_key callback? I suspect
> that'd affect a few drivers that are otherwise more or less orphaned.

Good idea.
It's costing next to nothing to enable it for for drivers without a 
set_key() callback, so I've just released v2 of the patch doing exactly 
that. I kept all the information what has changed since the last RFC 
series in the cover letter and the patches, so you can just ignore v1 of 
the patch and directly move to v2.

Alexander
diff mbox series

Patch

diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 0838af04d681..8cbadf825c76 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -2799,6 +2799,7 @@  static int mac80211_hwsim_new_radio(struct genl_info *info,
 	ieee80211_hw_set(hw, SIGNAL_DBM);
 	ieee80211_hw_set(hw, SUPPORTS_PS);
 	ieee80211_hw_set(hw, TDLS_WIDER_BW);
+	ieee80211_hw_set(hw, EXT_KEY_ID_NATIVE);
 	if (rctbl)
 		ieee80211_hw_set(hw, SUPPORTS_RC_TABLE);
 	ieee80211_hw_set(hw, SUPPORTS_MULTI_BSSID);