[v19,27/27] x86/sgx: Update MAINTAINERS
diff mbox series

Message ID 20190317211456.13927-28-jarkko.sakkinen@linux.intel.com
State New
Headers show
Series
  • Intel SGX1 support
Related show

Commit Message

Jarkko Sakkinen March 17, 2019, 9:14 p.m. UTC
Add the maintainer information for the SGX subsystem.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Sean Christopherson March 19, 2019, 5:12 p.m. UTC | #1
On Sun, Mar 17, 2019 at 11:14:56PM +0200, Jarkko Sakkinen wrote:
> Add the maintainer information for the SGX subsystem.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
>  MAINTAINERS | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e17ebf70b548..7abcb460dde9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8044,6 +8044,18 @@ L:	linux-gpio@vger.kernel.org
>  S:	Maintained
>  F:	drivers/gpio/gpio-intel-mid.c
>  
> +INTEL SGX

Alphabetically, this should slot in between "INTEL RDMA RNIC DRIVER" and
"INTEL TELEMETRY DRIVER".

Tangentially related, is it worth sending a patch to rename "INTEL-MID GPIO DRIVER"
to "INTEL MID GPIO DRIVER" and drop "(R)" from "INTEL(R) TRACE HUB"
and "INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)"?  They're silly
renegades that muck up the ordering.

> +M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> +M:	Sean Christopherson <sean.j.christopherson@intel.com>
> +L:	linux-sgx@vger.kernel.org
> +S:	Maintained
> +Q:	https://patchwork.kernel.org/project/intel-sgx/list/
> +T:	git https://github.com/jsakkine-intel/linux-sgx.git
> +F:	arch/x86/include/asm/sgx.h

arch/x86/include/asm/sgx.h doesn't exist in this version of the series.

> +F:	arch/x86/include/uapi/asm/sgx.h
> +F:	arch/x86/kernel/cpu/sgx/*

The trailing asterisk is unnecessary and wrong.  From MAINTAINER's docs:

        F: Files and directories with wildcard patterns.
           A trailing slash includes all files and subdirectory files.
           F:   drivers/net/    all files in and below drivers/net
           F:   drivers/net/*   all files in drivers/net, but not below

> +K:	\bSGX_
> +
>  INTERCONNECT API
>  M:	Georgi Djakov <georgi.djakov@linaro.org>
>  S:	Maintained
> -- 
> 2.19.1
>
Jarkko Sakkinen March 21, 2019, 2:42 p.m. UTC | #2
On Tue, Mar 19, 2019 at 10:12:29AM -0700, Sean Christopherson wrote:
> On Sun, Mar 17, 2019 at 11:14:56PM +0200, Jarkko Sakkinen wrote:
> > Add the maintainer information for the SGX subsystem.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > ---
> >  MAINTAINERS | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e17ebf70b548..7abcb460dde9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8044,6 +8044,18 @@ L:	linux-gpio@vger.kernel.org
> >  S:	Maintained
> >  F:	drivers/gpio/gpio-intel-mid.c
> >  
> > +INTEL SGX
> 
> Alphabetically, this should slot in between "INTEL RDMA RNIC DRIVER" and
> "INTEL TELEMETRY DRIVER".
> 
> Tangentially related, is it worth sending a patch to rename "INTEL-MID GPIO DRIVER"
> to "INTEL MID GPIO DRIVER" and drop "(R)" from "INTEL(R) TRACE HUB"
> and "INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)"?  They're silly
> renegades that muck up the ordering.

My bad. Placed it wrongly when I rebased the series to v5.0.

> 
> > +M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > +M:	Sean Christopherson <sean.j.christopherson@intel.com>
> > +L:	linux-sgx@vger.kernel.org
> > +S:	Maintained
> > +Q:	https://patchwork.kernel.org/project/intel-sgx/list/
> > +T:	git https://github.com/jsakkine-intel/linux-sgx.git
> > +F:	arch/x86/include/asm/sgx.h
> 
> arch/x86/include/asm/sgx.h doesn't exist in this version of the series.
> 
> > +F:	arch/x86/include/uapi/asm/sgx.h
> > +F:	arch/x86/kernel/cpu/sgx/*
> 
> The trailing asterisk is unnecessary and wrong.  From MAINTAINER's docs:
> 
>         F: Files and directories with wildcard patterns.
>            A trailing slash includes all files and subdirectory files.
>            F:   drivers/net/    all files in and below drivers/net
>            F:   drivers/net/*   all files in drivers/net, but not below
> 
> > +K:	\bSGX_
> > +
> >  INTERCONNECT API
> >  M:	Georgi Djakov <georgi.djakov@linaro.org>
> >  S:	Maintained
> > -- 
> > 2.19.1
> > 

Thanks. 

/Jarkko

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index e17ebf70b548..7abcb460dde9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8044,6 +8044,18 @@  L:	linux-gpio@vger.kernel.org
 S:	Maintained
 F:	drivers/gpio/gpio-intel-mid.c
 
+INTEL SGX
+M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
+M:	Sean Christopherson <sean.j.christopherson@intel.com>
+L:	linux-sgx@vger.kernel.org
+S:	Maintained
+Q:	https://patchwork.kernel.org/project/intel-sgx/list/
+T:	git https://github.com/jsakkine-intel/linux-sgx.git
+F:	arch/x86/include/asm/sgx.h
+F:	arch/x86/include/uapi/asm/sgx.h
+F:	arch/x86/kernel/cpu/sgx/*
+K:	\bSGX_
+
 INTERCONNECT API
 M:	Georgi Djakov <georgi.djakov@linaro.org>
 S:	Maintained