ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
diff mbox series

Message ID 20190317232124.7740-1-colin.king@canonical.com
State New
Headers show
Series
  • ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
Related show

Commit Message

Colin King March 17, 2019, 11:21 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The function snd_opl3_drum_switch declaration in the header file
has the order of the two arguments on_off and vel swapped when
compared to the definition arguments of vel and on_off.  Fix this
by swapping them around to match the definition.

This error predates the git history, so no idea when this error
was introduced.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/drivers/opl3/opl3_voice.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai March 18, 2019, 12:50 p.m. UTC | #1
On Mon, 18 Mar 2019 00:21:24 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function snd_opl3_drum_switch declaration in the header file
> has the order of the two arguments on_off and vel swapped when
> compared to the definition arguments of vel and on_off.  Fix this
> by swapping them around to match the definition.
> 
> This error predates the git history, so no idea when this error
> was introduced.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.


Takashi

Patch
diff mbox series

diff --git a/sound/drivers/opl3/opl3_voice.h b/sound/drivers/opl3/opl3_voice.h
index 5b02bd49fde4..4e4ecc21760b 100644
--- a/sound/drivers/opl3/opl3_voice.h
+++ b/sound/drivers/opl3/opl3_voice.h
@@ -41,7 +41,7 @@  void snd_opl3_timer_func(struct timer_list *t);
 
 /* Prototypes for opl3_drums.c */
 void snd_opl3_load_drums(struct snd_opl3 *opl3);
-void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int on_off, int vel, struct snd_midi_channel *chan);
+void snd_opl3_drum_switch(struct snd_opl3 *opl3, int note, int vel, int on_off, struct snd_midi_channel *chan);
 
 /* Prototypes for opl3_oss.c */
 #if IS_ENABLED(CONFIG_SND_SEQUENCER_OSS)