diff mbox series

drm/i915/psr: remove drmP.h include that crept in

Message ID 20190318160409.27648-1-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/psr: remove drmP.h include that crept in | expand

Commit Message

Jani Nikula March 18, 2019, 4:04 p.m. UTC
We've been free of deprecated drmP.h includes for a while, but one crept
in. Fend it off.

Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Souza, Jose March 18, 2019, 7:40 p.m. UTC | #1
On Mon, 2019-03-18 at 18:04 +0200, Jani Nikula wrote:
> We've been free of deprecated drmP.h includes for a while, but one
> crept
> in. Fend it off.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> 
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_psr.c
> b/drivers/gpu/drm/i915/intel_psr.c
> index 7d570a45fc17..29aa0e90cc0c 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -51,7 +51,6 @@
>   * must be correctly synchronized/cancelled when shutting down the
> pipe."
>   */
>  
> -#include <drm/drmP.h>
>  #include <drm/drm_atomic_helper.h>
>  
>  #include "intel_drv.h"
Jani Nikula March 19, 2019, 8:19 a.m. UTC | #2
On Tue, 19 Mar 2019, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/psr: remove drmP.h include that crept in
> URL   : https://patchwork.freedesktop.org/series/58136/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_5768_full -> Patchwork_12501_full
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_12501_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_12501_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_12501_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
>     - shard-iclb:         PASS -> INCOMPLETE

I don't think so.

Pushed, thanks for the review.

BR,
Jani.

>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_12501_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@gem_exec_schedule@fifo-bsd2:
>     - shard-snb:          NOTRUN -> SKIP [fdo#109271] +74
>
>   * igt@gem_exec_schedule@preempt-other-chain-bsd2:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109276] +1
>
>   * igt@gem_ppgtt@blt-vs-render-ctx0:
>     - shard-iclb:         PASS -> INCOMPLETE [fdo#109100] / [fdo#109766] / [fdo#109801]
>
>   * igt@gem_pread@stolen-uncached:
>     - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +21
>
>   * igt@gem_tiled_fence_blits@normal:
>     - shard-iclb:         PASS -> TIMEOUT [fdo#109673] +1
>
>   * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109308]
>
>   * igt@i915_pm_rpm@gem-idle:
>     - shard-skl:          PASS -> INCOMPLETE [fdo#107807]
>
>   * igt@i915_suspend@fence-restore-untiled:
>     - shard-iclb:         PASS -> FAIL [fdo#103375]
>
>   * igt@kms_atomic_transition@6x-modeset-transitions-nonblocking:
>     - shard-hsw:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
>
>   * igt@kms_busy@extended-modeset-hang-newfb-render-a:
>     - shard-skl:          NOTRUN -> DMESG-WARN [fdo#107956] +1
>
>   * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-e:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109278] +1
>
>   * igt@kms_busy@extended-modeset-hang-oldfb-render-d:
>     - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
>
>   * igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-c:
>     - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +9
>
>   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
>     - shard-glk:          PASS -> FAIL [fdo#108145]
>     - shard-iclb:         PASS -> FAIL [fdo#107725]
>
>   * igt@kms_chamelium@hdmi-crc-abgr8888:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109284] +1
>
>   * igt@kms_color@pipe-a-legacy-gamma:
>     - shard-apl:          PASS -> FAIL [fdo#104782] / [fdo#108145]
>
>   * igt@kms_color@pipe-b-ctm-0-75:
>     - shard-skl:          PASS -> FAIL [fdo#108682]
>
>   * igt@kms_color@pipe-b-gamma:
>     - shard-iclb:         NOTRUN -> FAIL [fdo#104782] +1
>
>   * igt@kms_color@pipe-c-degamma:
>     - shard-apl:          PASS -> FAIL [fdo#104782]
>
>   * igt@kms_content_protection@legacy:
>     - shard-kbl:          NOTRUN -> FAIL [fdo#108597] / [fdo#108739]
>
>   * igt@kms_cursor_crc@cursor-256x256-sliding:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103232]
>
>   * igt@kms_cursor_crc@cursor-256x85-random:
>     - shard-apl:          PASS -> FAIL [fdo#103232] +5
>
>   * igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
>     - shard-iclb:         PASS -> FAIL [fdo#103355]
>
>   * igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
>     - shard-skl:          PASS -> FAIL [fdo#103184]
>
>   * igt@kms_flip@2x-modeset-vs-vblank-race:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109274]
>
>   * igt@kms_flip_tiling@flip-y-tiled:
>     - shard-skl:          PASS -> FAIL [fdo#108303]
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>     - shard-iclb:         PASS -> FAIL [fdo#103167] +11
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-wc:
>     - shard-skl:          PASS -> FAIL [fdo#105682]
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
>     - shard-apl:          PASS -> FAIL [fdo#103167] +1
>
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-apl:          PASS -> FAIL [fdo#103375]
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103167] +1
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109280] +4
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite:
>     - shard-iclb:         PASS -> FAIL [fdo#105682] / [fdo#109247] +1
>
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
>     - shard-iclb:         PASS -> FAIL [fdo#109247] +12
>
>   * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt:
>     - shard-hsw:          NOTRUN -> SKIP [fdo#109271] +9
>
>   * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
>     - shard-skl:          PASS -> FAIL [fdo#103167] +1
>
>   * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103191] / [fdo#107362]
>
>   * igt@kms_pipe_crc_basic@read-crc-pipe-a:
>     - shard-skl:          PASS -> FAIL [fdo#107362]
>
>   * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>     - shard-skl:          PASS -> FAIL [fdo#107815] / [fdo#108145]
>
>   * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
>     - shard-kbl:          NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
>
>   * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
>     - shard-skl:          NOTRUN -> FAIL [fdo#108145]
>
>   * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
>     - shard-skl:          PASS -> FAIL [fdo#108145]
>
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          NOTRUN -> FAIL [fdo#107815]
>
>   * igt@kms_plane_lowres@pipe-a-tiling-x:
>     - shard-iclb:         PASS -> FAIL [fdo#103166]
>
>   * igt@kms_plane_scaling@2x-scaler-multi-pipe:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109274] / [fdo#109278]
>
>   * igt@kms_psr2_su@page_flip:
>     - shard-iclb:         PASS -> SKIP [fdo#109642]
>
>   * igt@kms_psr@cursor_mmap_gtt:
>     - shard-iclb:         PASS -> FAIL [fdo#107383]
>
>   * igt@kms_psr@psr2_cursor_plane_onoff:
>     - shard-iclb:         PASS -> SKIP [fdo#109441] +1
>
>   * igt@kms_universal_plane@disable-primary-vs-flip-pipe-f:
>     - shard-skl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
>
>   * igt@kms_vblank@pipe-c-ts-continuation-modeset:
>     - shard-kbl:          NOTRUN -> FAIL [fdo#104894]
>
>   * igt@kms_vblank@pipe-c-ts-continuation-suspend:
>     - shard-skl:          NOTRUN -> INCOMPLETE [fdo#104108] / [fdo#107773]
>
>   * igt@prime_nv_pcopy@test_semaphore:
>     - shard-iclb:         NOTRUN -> SKIP [fdo#109291]
>
>   * igt@prime_vgem@sync-bsd2:
>     - shard-skl:          NOTRUN -> SKIP [fdo#109271] +52
>
>   
> #### Possible fixes ####
>
>   * igt@gem_media_vme:
>     - shard-glk:          FAIL -> PASS
>
>   * igt@gem_partial_pwrite_pread@write-uncached:
>     - shard-iclb:         TIMEOUT [fdo#109673] -> PASS
>
>   * igt@i915_pm_rpm@sysfs-read:
>     - shard-skl:          INCOMPLETE [fdo#107807] -> PASS +1
>
>   * igt@kms_addfb_basic@small-bo:
>     - shard-iclb:         INCOMPLETE [fdo#109100] -> PASS
>
>   * igt@kms_chv_cursor_fail@pipe-b-128x128-left-edge:
>     - shard-skl:          FAIL [fdo#104671] -> PASS
>
>   * igt@kms_color@pipe-a-ctm-max:
>     - shard-skl:          FAIL [fdo#108147] -> PASS
>
>   * igt@kms_cursor_crc@cursor-64x21-random:
>     - shard-apl:          FAIL [fdo#103232] -> PASS +1
>
>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>     - shard-hsw:          FAIL [fdo#105767] -> PASS
>
>   * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
>     - shard-skl:          FAIL [fdo#103184] -> PASS
>
>   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>     - shard-glk:          FAIL [fdo#105363] -> PASS
>
>   * igt@kms_flip@2x-plain-flip-fb-recreate:
>     - shard-glk:          FAIL [fdo#100368] -> PASS
>
>   * igt@kms_flip@flip-vs-blocking-wf-vblank:
>     - shard-skl:          FAIL [fdo#100368] -> PASS
>
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          FAIL [fdo#105363] -> PASS
>
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-skl:          INCOMPLETE [fdo#107773] / [fdo#109507] -> PASS
>
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>     - shard-apl:          FAIL [fdo#103167] -> PASS
>
>   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
>     - shard-glk:          FAIL [fdo#103167] -> PASS +3
>
>   * igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
>     - shard-iclb:         FAIL [fdo#103167] -> PASS +4
>
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
>     - shard-iclb:         FAIL [fdo#109247] -> PASS +18
>
>   * {igt@kms_plane@pixel-format-pipe-a-planes}:
>     - shard-iclb:         FAIL -> PASS
>
>   * {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
>     - shard-glk:          SKIP [fdo#109271] -> PASS
>
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
>     - shard-skl:          INCOMPLETE [fdo#104108] -> PASS
>
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          FAIL [fdo#107815] -> PASS
>
>   * {igt@kms_plane_multiple@atomic-pipe-c-tiling-yf}:
>     - shard-apl:          FAIL [fdo#110037] -> PASS +1
>     - shard-iclb:         FAIL [fdo#110037] -> PASS +1
>
>   * igt@kms_psr@no_drrs:
>     - shard-iclb:         FAIL [fdo#108341] -> PASS
>
>   * igt@kms_psr@psr2_sprite_render:
>     - shard-iclb:         SKIP [fdo#109441] -> PASS +1
>
>   * igt@kms_psr@sprite_blt:
>     - shard-iclb:         FAIL [fdo#107383] -> PASS +3
>
>   * igt@kms_setmode@basic:
>     - shard-apl:          FAIL [fdo#99912] -> PASS
>
>   * igt@kms_vblank@pipe-c-ts-continuation-suspend:
>     - shard-hsw:          INCOMPLETE [fdo#103540] -> PASS
>
>   
> #### Warnings ####
>
>   * igt@gem_tiled_swapping@non-threaded:
>     - shard-iclb:         FAIL -> DMESG-WARN [fdo#108686]
>
>   * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
>     - shard-skl:          SKIP [fdo#109271] -> INCOMPLETE [fdo#107807]
>
>   * igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
>     - shard-glk:          SKIP [fdo#109271] / [fdo#109278] -> FAIL [fdo#110098]
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
>   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
>   [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   [fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
>   [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
>   [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
>   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>   [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
>   [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
>   [fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
>   [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
>   [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
>   [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
>   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
>   [fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
>   [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
>   [fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
>   [fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
>   [fdo#108682]: https://bugs.freedesktop.org/show_bug.cgi?id=108682
>   [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
>   [fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
>   [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
>   [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
>   [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
>   [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
>   [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
>   [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
>   [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
>   [fdo#109766]: https://bugs.freedesktop.org/show_bug.cgi?id=109766
>   [fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801
>   [fdo#110033]: https://bugs.freedesktop.org/show_bug.cgi?id=110033
>   [fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
>   [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
>   [fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> Participating hosts (10 -> 10)
> ------------------------------
>
>   No changes in participating hosts
>
>
> Build changes
> -------------
>
>     * Linux: CI_DRM_5768 -> Patchwork_12501
>
>   CI_DRM_5768: e9ff09b836a2473adacf7eb108af0348d91cd136 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_12501: b8476a7eacb27a240d1d63183102ddcc8a371c0a @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12501/
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 7d570a45fc17..29aa0e90cc0c 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -51,7 +51,6 @@ 
  * must be correctly synchronized/cancelled when shutting down the pipe."
  */
 
-#include <drm/drmP.h>
 #include <drm/drm_atomic_helper.h>
 
 #include "intel_drv.h"