| Message ID | 20190318174228.18194-5-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mfd: add support for max77650 PMIC | expand |
On Mon 2019-03-18 18:42:21, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Add the DT binding document for the onkey module of max77650. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Reviewed-by: Rob Herring <robh@kernel.org> > + onkey { > + compatible = "maxim,max77650-onkey"; > + linux,code = <KEY_END>; > + maxim,onkey-slide; > + }; This is certainly wrong. "End" key is normal key on a keyboard, certainly not some kind of slider. And this controller is likely to be used for power key, not end key, right? Pavel
pt., 22 mar 2019 o 10:09 Pavel Machek <pavel@ucw.cz> napisał(a): > > On Mon 2019-03-18 18:42:21, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Add the DT binding document for the onkey module of max77650. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > > + onkey { > > + compatible = "maxim,max77650-onkey"; > > + linux,code = <KEY_END>; > > + maxim,onkey-slide; > > + }; > > This is certainly wrong. > > "End" key is normal key on a keyboard, certainly not some kind of > slider. > > And this controller is likely to be used for power key, not end key, > right? But this is just an example of available properties, not a real use-case. Bart > > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Fri 2019-03-22 10:55:26, Bartosz Golaszewski wrote: > pt., 22 mar 2019 o 10:09 Pavel Machek <pavel@ucw.cz> napisał(a): > > > > On Mon 2019-03-18 18:42:21, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > Add the DT binding document for the onkey module of max77650. > > > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > > + onkey { > > > + compatible = "maxim,max77650-onkey"; > > > + linux,code = <KEY_END>; > > > + maxim,onkey-slide; > > > + }; > > > > This is certainly wrong. > > > > "End" key is normal key on a keyboard, certainly not some kind of > > slider. > > > > And this controller is likely to be used for power key, not end key, > > right? > > But this is just an example of available properties, not a real use-case. We can have example that makes sense, right? Pavel
diff --git a/Documentation/devicetree/bindings/input/max77650-onkey.txt b/Documentation/devicetree/bindings/input/max77650-onkey.txt new file mode 100644 index 000000000000..477dc74f452a --- /dev/null +++ b/Documentation/devicetree/bindings/input/max77650-onkey.txt @@ -0,0 +1,26 @@ +Onkey driver for MAX77650 PMIC from Maxim Integrated. + +This module is part of the MAX77650 MFD device. For more details +see Documentation/devicetree/bindings/mfd/max77650.txt. + +The onkey controller is represented as a sub-node of the PMIC node on +the device tree. + +Required properties: +-------------------- +- compatible: Must be "maxim,max77650-onkey". + +Optional properties: +- linux,code: The key-code to be reported when the key is pressed. + Defaults to KEY_POWER. +- maxim,onkey-slide: The system's button is a slide switch, not the default + push button. + +Example: +-------- + + onkey { + compatible = "maxim,max77650-onkey"; + linux,code = <KEY_END>; + maxim,onkey-slide; + };