From patchwork Mon Mar 18 23:04:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 10858603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B93615AC for ; Mon, 18 Mar 2019 23:04:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26AC528748 for ; Mon, 18 Mar 2019 23:04:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1AACB291D0; Mon, 18 Mar 2019 23:04:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B094E28748 for ; Mon, 18 Mar 2019 23:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=RnGz8DeeYNcPb7JpRx1dtXTXJF9FwaqAS9OBQFSJyME=; b=E5W imHkJjXyv+qMgm202HEM7glc7BzMRNmiaPZ4bwMqZLOkO5raxK+BnOSTczMFE2MIyOb4xFZHnDxPa mdh5eWmfV/C5VHeYt2x5aYBT3WKnncF2RY3E2NmOxmccxLVBXbT3dJUGdC+dGIesiqP46c8dLgpMJ Xz4SYj+ZkfIgR9irbJu0+4MVmB9ka36DmP8NLJk0zpa56gw2tEKh+rhgRRrT048Y1tgEfVCvxYYKM e+lzXqKTqpJoMqJe0YS7bTJjQFTearSOUM0ZS1ZycjZ4xUFHp+9NY/+Lrso4vyQtKjCAj4eOd5Ls+ LcaCtZ3XXR/QveSKplE5u8Csmv4ZroA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h61JE-0005lE-KH; Mon, 18 Mar 2019 23:04:44 +0000 Received: from mta-p5.oit.umn.edu ([134.84.196.205]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h61JB-0005kT-Nz for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 23:04:43 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 3B9B0B39 for ; Mon, 18 Mar 2019 23:04:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o17kdA_NrSYH for ; Mon, 18 Mar 2019 18:04:38 -0500 (CDT) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id 1191F976 for ; Mon, 18 Mar 2019 18:04:38 -0500 (CDT) Received: by mail-io1-f72.google.com with SMTP id s24so10932403ioe.17 for ; Mon, 18 Mar 2019 16:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=r+eUpa3ovVvi2jvnpoCV250+eraJD6oc+4vj8+nrBpo=; b=CPBt6c/Y5sfB35HnLXEAfSdjV1AeuayWKomQ5lpoECDMoPXnSaDsx6j2CglKRsnNEh uggzNFdrC7Qn1K4KX4g7UlOPMpRPxBoyNv+nSvCDQsN5Eln7lolo+O13MZv7FFXJcHjZ 9xdScl6FYfGRknNjVD95OaaqdGKYj7j+aPmeZG6fbNgLBfbzYFckyiio3WuAAT9vLFPv fwcYIDX+J9bagyE/+HYcj7WbZGupvOVXCQNNZBbnNDykJWY/Go+/EBc+Atrp3d3NHEJ1 DNeKY6l+6MaX8gwfxHvJ/ENyZgF045tHRu8KqzdQ8pgEFPDAp+NtfJnnhbFhJxd2FSG+ ChpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=r+eUpa3ovVvi2jvnpoCV250+eraJD6oc+4vj8+nrBpo=; b=j9xBfOcYp9gSJvaTDfMgqxYlKztS9CiaPNyh5KZ0TzJBGmaH/M+R/7apDLJICoHe64 zG8Bs28OMLl/riz1HBTEeZeOlqPuayS7hjJasFf05YC9SLcnWrucyeJW2ZCKTdVU2Kt4 B08i/3rg4U9PR4BmJGu1I2YCvha6CAdrUUg87lo8x9ig7Mv2GsLNHhJ0e7+dCUYF9W+f rSkW5mu5CLIvBTQxrcBl5GWIViSNbWsj5pzsvcg8rn9a3UGaumrUgsMgp1og2+u1Y20L 1zTwKBQN59YYWZg4IFjp26SC347YX8jC5g/hKOqRVrtPPW1CSEdFLKlpDMpzcFrMZMpR b51g== X-Gm-Message-State: APjAAAVq6tf4zxd00AQQtcDLqtetwDcbBr75QSwVX6GG/uQnsPQSMn9Z AyKA7/VhiXjQHIUz5O7jZgWs6F/5B1NLYu2be9W59cS2PyBQveC1HkzgOzajx/mKAwXuyvWhFFU dv8WoPtCXNPuwEJPpBhGW0/RDFO1+WyWPujM0KKs= X-Received: by 2002:a24:2251:: with SMTP id o78mr932970ito.134.1552950277560; Mon, 18 Mar 2019 16:04:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqwf3cdqM6bIUchuphcQjV4XHh5DwgbU6QDebzJwSbXHDdqK4cCphNA2dpQrydGSglmxecVnkg== X-Received: by 2002:a24:2251:: with SMTP id o78mr932951ito.134.1552950277360; Mon, 18 Mar 2019 16:04:37 -0700 (PDT) Received: from lenovo-1.hsd1.mn.comcast.net (c-73-242-25-233.hsd1.mn.comcast.net. [73.242.25.233]) by smtp.googlemail.com with ESMTPSA id n21sm4765957ioo.3.2019.03.18.16.04.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 16:04:36 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Subject: [PATCH] firmware: arm_scmi: Fix to check return value of of_match_device Date: Mon, 18 Mar 2019 18:04:30 -0500 Message-Id: <20190318230430.8273-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_160441_877021_EF3C904B X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kjlu@umn.edu, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP of_match_device can return NULL if no matching device is found. This patch checks and returns -ENODEV in such a scenario. Signed-off-by: Aditya Pakki --- drivers/firmware/arm_scmi/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 8f952f2f1a29..0e0330b44b7b 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -799,6 +799,8 @@ static int scmi_probe(struct platform_device *pdev) } desc = of_match_device(scmi_of_match, dev)->data; + if (!desc) + return -ENODEV; info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); if (!info)