| Message ID | 20190319060418.29575-1-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] btrfs: Make btrfs_(set|clear)_header_flag return void | expand |
On 19.03.19 г. 8:04 ч., Qu Wenruo wrote: > From the introduce of btrfs_(set|clear)_header_flag, there is no usage > of its return value. > > So just make it return void. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/ctree.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index b3642367a595..c03852d1aa34 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -2163,18 +2163,16 @@ static inline int btrfs_header_flag(const struct extent_buffer *eb, u64 flag) > return (btrfs_header_flags(eb) & flag) == flag; > } > > -static inline int btrfs_set_header_flag(struct extent_buffer *eb, u64 flag) > +static inline void btrfs_set_header_flag(struct extent_buffer *eb, u64 flag) > { > u64 flags = btrfs_header_flags(eb); > btrfs_set_header_flags(eb, flags | flag); > - return (flags & flag) == flag; > } > > -static inline int btrfs_clear_header_flag(struct extent_buffer *eb, u64 flag) > +static inline void btrfs_clear_header_flag(struct extent_buffer *eb, u64 flag) > { > u64 flags = btrfs_header_flags(eb); > btrfs_set_header_flags(eb, flags & ~flag); > - return (flags & flag) == flag; > } > > static inline int btrfs_header_backref_rev(const struct extent_buffer *eb) >
On Tue, Mar 19, 2019 at 02:04:17PM +0800, Qu Wenruo wrote: > >From the introduce of btrfs_(set|clear)_header_flag, there is no usage > of its return value. > > So just make it return void. > > Signed-off-by: Qu Wenruo <wqu@suse.com> This is an independent patch so I'll add it to misc-next, thanks. Reviewed-by: David Sterba <dsterba@suse.com>
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index b3642367a595..c03852d1aa34 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -2163,18 +2163,16 @@ static inline int btrfs_header_flag(const struct extent_buffer *eb, u64 flag) return (btrfs_header_flags(eb) & flag) == flag; } -static inline int btrfs_set_header_flag(struct extent_buffer *eb, u64 flag) +static inline void btrfs_set_header_flag(struct extent_buffer *eb, u64 flag) { u64 flags = btrfs_header_flags(eb); btrfs_set_header_flags(eb, flags | flag); - return (flags & flag) == flag; } -static inline int btrfs_clear_header_flag(struct extent_buffer *eb, u64 flag) +static inline void btrfs_clear_header_flag(struct extent_buffer *eb, u64 flag) { u64 flags = btrfs_header_flags(eb); btrfs_set_header_flags(eb, flags & ~flag); - return (flags & flag) == flag; } static inline int btrfs_header_backref_rev(const struct extent_buffer *eb)
From the introduce of btrfs_(set|clear)_header_flag, there is no usage of its return value. So just make it return void. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/btrfs/ctree.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)