| Message ID | 1552977898-5590-5-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add i.MX7ULP EVK PWM backlight support | expand |
On Tue, Mar 19, 2019 at 06:50:26AM +0000, Anson Huang wrote: > Add i.MX7ULP EVK board PWM0 support. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V5: > - change #pwm-cells to 3. > --- > arch/arm/boot/dts/imx7ulp-evk.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++++++ IMHO the change to the evk.dts belongs into the last patch. Best regards Uwe
Best Regards! Anson Huang > -----Original Message----- > From: Uwe Kleine-König [mailto:u.kleine-koenig@pengutronix.de] > Sent: 2019年3月19日 14:55 > To: Anson Huang <anson.huang@nxp.com> > Cc: thierry.reding@gmail.com; robh+dt@kernel.org; mark.rutland@arm.com; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch; > otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>; > schnitzeltony@gmail.com; jan.tuerk@emtrion.com; Robin Gong > <yibin.gong@nxp.com>; linux-pwm@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V6 4/5] ARM: dts: imx7ulp: Add pwm0 support > > On Tue, Mar 19, 2019 at 06:50:26AM +0000, Anson Huang wrote: > > Add i.MX7ULP EVK board PWM0 support. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > Changes since V5: > > - change #pwm-cells to 3. > > --- > > arch/arm/boot/dts/imx7ulp-evk.dts | 12 ++++++++++++ > > arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++++++ > > IMHO the change to the evk.dts belongs into the last patch. Ah, yes, the PWM pin settings in board dts should belongs into the backlight patch, I will resend V6, thanks. Anson. > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p > engutronix.de%2F&data=02%7C01%7Canson.huang%40nxp.com%7Ce3 > 645a6d4d6643a1f80f08d6ac37c725%7C686ea1d3bc2b4c6fa92cd99c5c301635 > %7C0%7C0%7C636885752897208572&sdata=N67sms9lX6asXpYaq%2Ftf > TNpNz%2BeDIKNx89%2F57CYQAwA%3D&reserved=0 |
diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts b/arch/arm/boot/dts/imx7ulp-evk.dts index a09026a..3f5ea18 100644 --- a/arch/arm/boot/dts/imx7ulp-evk.dts +++ b/arch/arm/boot/dts/imx7ulp-evk.dts @@ -40,6 +40,12 @@ status = "okay"; }; +&pwm0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0>; + status = "okay"; +}; + &usdhc0 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usdhc0>; @@ -57,6 +63,12 @@ bias-pull-up; }; + pinctrl_pwm0: pwm0grp { + fsl,pins = < + IMX7ULP_PAD_PTF2__TPM4_CH1 0x2 + >; + }; + pinctrl_usdhc0: usdhc0grp { fsl,pins = < IMX7ULP_PAD_PTD1__SDHC0_CMD 0x43 diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi index eb349fd..15d04fb 100644 --- a/arch/arm/boot/dts/imx7ulp.dtsi +++ b/arch/arm/boot/dts/imx7ulp.dtsi @@ -124,6 +124,16 @@ status = "disabled"; }; + pwm0: pwm@40250000 { + compatible = "fsl,imx-tpm"; + reg = <0x40250000 0x1000>; + assigned-clocks = <&pcc2 IMX7ULP_CLK_LPTPM4>; + assigned-clock-parents = <&scg1 IMX7ULP_CLK_SOSC_BUS_CLK>; + clocks = <&pcc2 IMX7ULP_CLK_LPTPM4>; + #pwm-cells = <3>; + status = "disabled"; + }; + tpm5: tpm@40260000 { compatible = "fsl,imx7ulp-tpm"; reg = <0x40260000 0x1000>;
Add i.MX7ULP EVK board PWM0 support. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V5: - change #pwm-cells to 3. --- arch/arm/boot/dts/imx7ulp-evk.dts | 12 ++++++++++++ arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++++++ 2 files changed, 22 insertions(+)