diff mbox series

[-next] crypto: ccp - Make ccp_register_rsa_alg static

Message ID 20190319135035.22056-1-yuehaibing@huawei.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series [-next] crypto: ccp - Make ccp_register_rsa_alg static | expand

Commit Message

Yue Haibing March 19, 2019, 1:50 p.m. UTC 
From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
 warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Gary R Hook March 19, 2019, 6:39 p.m. UTC | #1 
On 3/19/19 8:50 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
>   warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Gary R Hook <gary.hook@amd.com.

> ---
>   drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
> index 05850df..0b8aab00 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -248,7 +248,8 @@ static struct ccp_rsa_def rsa_algs[] = {
>   	}
>   };
>   
> -int ccp_register_rsa_alg(struct list_head *head, const struct ccp_rsa_def *def)
> +static int ccp_register_rsa_alg(struct list_head *head,
> +			        const struct ccp_rsa_def *def)
>   {
>   	struct ccp_crypto_akcipher_alg *ccp_alg;
>   	struct akcipher_alg *alg;
>
Herbert Xu March 28, 2019, 6:06 a.m. UTC | #2 
On Tue, Mar 19, 2019 at 09:50:35PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
>  warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
index 05850df..0b8aab00 100644
--- a/drivers/crypto/ccp/ccp-crypto-rsa.c
+++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
@@ -248,7 +248,8 @@  static struct ccp_rsa_def rsa_algs[] = {
 	}
 };
 
-int ccp_register_rsa_alg(struct list_head *head, const struct ccp_rsa_def *def)
+static int ccp_register_rsa_alg(struct list_head *head,
+			        const struct ccp_rsa_def *def)
 {
 	struct ccp_crypto_akcipher_alg *ccp_alg;
 	struct akcipher_alg *alg;