| Message ID | 20190320064723.46604-1-wanghai26@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static | expand |
On 20/03/2019 17:47, Wang Hai wrote: > Fixes the following sparse warning: > > drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning: > symbol 'tce_iommu_driver_ops' was not declared. Should it be static? > > Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO") > Signed-off-by: Wang Hai <wanghai26@huawei.com> I am curious - what exactly did you do to get this warning? Anyway, Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru> > --- > drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c > index 8dbb270..6b64e45 100644 > --- a/drivers/vfio/vfio_iommu_spapr_tce.c > +++ b/drivers/vfio/vfio_iommu_spapr_tce.c > @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data, > mutex_unlock(&container->lock); > } > > -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { > +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { > .name = "iommu-vfio-powerpc", > .owner = THIS_MODULE, > .open = tce_iommu_open, >
On Wed, 20 Mar 2019 02:47:23 -0400 Wang Hai <wanghai26@huawei.com> wrote: > Fixes the following sparse warning: > > drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning: > symbol 'tce_iommu_driver_ops' was not declared. Should it be static? > > Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO") > Signed-off-by: Wang Hai <wanghai26@huawei.com> > --- Applied to vfio for-linus branch for v5.1 with Alexey's R-b. Thanks! Alex > drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c > index 8dbb270..6b64e45 100644 > --- a/drivers/vfio/vfio_iommu_spapr_tce.c > +++ b/drivers/vfio/vfio_iommu_spapr_tce.c > @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data, > mutex_unlock(&container->lock); > } > > -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { > +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { > .name = "iommu-vfio-powerpc", > .owner = THIS_MODULE, > .open = tce_iommu_open,
diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c index 8dbb270..6b64e45 100644 --- a/drivers/vfio/vfio_iommu_spapr_tce.c +++ b/drivers/vfio/vfio_iommu_spapr_tce.c @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data, mutex_unlock(&container->lock); } -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { .name = "iommu-vfio-powerpc", .owner = THIS_MODULE, .open = tce_iommu_open,
Fixes the following sparse warning: drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning: symbol 'tce_iommu_driver_ops' was not declared. Should it be static? Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO") Signed-off-by: Wang Hai <wanghai26@huawei.com> --- drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)