diff mbox series

[RFC,asoc] ASoC: wm_adsp: wm_adsp1_ops can be static

Message ID 20190319150006.GA15014@lkp-wsm-ep2 (mailing list archive)
State New, archived
Headers show
Series [RFC,asoc] ASoC: wm_adsp: wm_adsp1_ops can be static | expand

Commit Message

kernel test robot March 19, 2019, 3 p.m. UTC
Fixes: 4e08d50d1fb6 ("ASoC: wm_adsp: Factor out DSP specific operations")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 wm_adsp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Charles Keepax March 19, 2019, 4:36 p.m. UTC | #1
On Tue, Mar 19, 2019 at 11:00:06PM +0800, kbuild test robot wrote:
> 
> Fixes: 4e08d50d1fb6 ("ASoC: wm_adsp: Factor out DSP specific operations")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
Charles Keepax March 19, 2019, 5:37 p.m. UTC | #2
On Tue, Mar 19, 2019 at 11:00:06PM +0800, kbuild test robot wrote:
> 
> Fixes: 4e08d50d1fb6 ("ASoC: wm_adsp: Factor out DSP specific operations")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  wm_adsp.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
> index 644aaf1..2a9554d 100644
> --- a/sound/soc/codecs/wm_adsp.c
> +++ b/sound/soc/codecs/wm_adsp.c
> @@ -306,8 +306,8 @@
>  #define HALO_MPU_VIO_ERR_SRC_MASK           0x00007fff
>  #define HALO_MPU_VIO_ERR_SRC_SHIFT                   0
>  
> -struct wm_adsp_ops wm_adsp1_ops;
> -struct wm_adsp_ops wm_adsp2_ops[];
> +static struct wm_adsp_ops wm_adsp1_ops;
> +static struct wm_adsp_ops wm_adsp2_ops[];
>  struct wm_adsp_ops wm_halo_ops;
>  
>  struct wm_adsp_buf {

Actually testing these they need to update the implementation as
well.

Will send a patch.

Thanks,
Charles
diff mbox series

Patch

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 644aaf1..2a9554d 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -306,8 +306,8 @@ 
 #define HALO_MPU_VIO_ERR_SRC_MASK           0x00007fff
 #define HALO_MPU_VIO_ERR_SRC_SHIFT                   0
 
-struct wm_adsp_ops wm_adsp1_ops;
-struct wm_adsp_ops wm_adsp2_ops[];
+static struct wm_adsp_ops wm_adsp1_ops;
+static struct wm_adsp_ops wm_adsp2_ops[];
 struct wm_adsp_ops wm_halo_ops;
 
 struct wm_adsp_buf {