[PULL,0/3] Filemon next patches
mbox

Message ID 20190320174150.12067-1-berrange@redhat.com
State New
Headers show

Pull-request

https://github.com/berrange/qemu tags/filemon-next-pull-request

Message

Daniel P. Berrangé March 20, 2019, 5:41 p.m. UTC
The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2:

  Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +0000)

are available in the Git repository at:

  https://github.com/berrange/qemu tags/filemon-next-pull-request

for you to fetch changes up to 9c8cc692ccda6912e46a4b13c4bbcd42df3e8673:

  filemon: fix watch IDs to avoid potential wraparound issues (2019-03-20 17:03:29 +0000)

----------------------------------------------------------------
Fix watch uniqueness and protect against guest triggered
integer wraparound clashes in watches.

----------------------------------------------------------------

Daniel P. Berrangé (3):
  tests: refactor file monitor test to make it more understandable
  filemon: ensure watch IDs are unique to QFileMonitor scope
  filemon: fix watch IDs to avoid potential wraparound issues

 authz/listfile.c              |   2 +-
 hw/usb/dev-mtp.c              |  10 +-
 include/authz/listfile.h      |   2 +-
 include/qemu/filemonitor.h    |  16 +-
 tests/test-util-filemonitor.c | 626 +++++++++++++++++-----------------
 util/filemonitor-inotify.c    |  26 +-
 util/filemonitor-stub.c       |   4 +-
 util/trace-events             |   6 +-
 8 files changed, 337 insertions(+), 355 deletions(-)

Comments

no-reply@patchew.org March 20, 2019, 5:55 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20190320174150.12067-1-berrange@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

clang -iquote /tmp/qemu-test/build/. -iquote . -iquote /tmp/qemu-test/src/tcg -iquote /tmp/qemu-test/src/tcg/i386 -I/tmp/qemu-test/src/linux-headers -I/tmp/qemu-test/build/linux-headers -iquote . -iquote /tmp/qemu-test/src -iquote /tmp/qemu-test/src/accel/tcg -iquote /tmp/qemu-test/src/include -I/tmp/qemu-test/src/tests/fp -I/tmp/qemu-test/src/tests/fp/berkeley-softfloat-3/source/include -I/tmp/qemu-test/src/tests/fp/berkeley-softfloat-3/source/8086-SSE -I/tmp/qemu-test/src/tests/fp/berkeley-testfloat-3/source -I/usr/include/pixman-1 -I/tmp/qemu-test/src/dtc/libfdt -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss3 -I/usr/include/nspr4 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pixman-1 -DHW_POISON_H -DTARGET_ARM  -DSOFTFLOAT_ROUND_ODD -DINLINE_LEVEL=5 -DSOFTFLOAT_FAST_DIV32TO16 -DSOFTFLOAT_FAST_DIV64TO32 -DSOFTFLOAT_FAST_INT64  -DFLOAT16 -DFLOAT64 -DEXTFLOAT80 -DFLOAT128 -DFLOAT_ROUND_ODD -DLONG_DOUBLE_IS_EXTFLOAT80  -Wno-strict-prototypes -Wno-unknown-pragmas -Wno-uninitialized -Wno-missing-prototypes -Wno-return-type -Wno-unused-function -Wno-error -MMD -MP -MT writeCase_ab_f64.o -MF ./writeCase_ab_f64.d -fsanitize=undefined -fsanitize=address -g   -c -o writeCase_ab_f64.o /tmp/qemu-test/src/tests/fp/berkeley-testfloat-3/source/writeCase_ab_f64.c
make[1]: Leaving directory '/tmp/qemu-test/build/x86_64-softmmu'
clang -iquote /tmp/qemu-test/build/. -iquote . -iquote /tmp/qemu-test/src/tcg -iquote /tmp/qemu-test/src/tcg/i386 -I/tmp/qemu-test/src/linux-headers -I/tmp/qemu-test/build/linux-headers -iquote . -iquote /tmp/qemu-test/src -iquote /tmp/qemu-test/src/accel/tcg -iquote /tmp/qemu-test/src/include -I/tmp/qemu-test/src/tests/fp -I/tmp/qemu-test/src/tests/fp/berkeley-softfloat-3/source/include -I/tmp/qemu-test/src/tests/fp/berkeley-softfloat-3/source/8086-SSE -I/tmp/qemu-test/src/tests/fp/berkeley-testfloat-3/source -I/usr/include/pixman-1 -I/tmp/qemu-test/src/dtc/libfdt -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss3 -I/usr/include/nspr4 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pixman-1 -DHW_POISON_H -DTARGET_ARM  -DSOFTFLOAT_ROUND_ODD -DINLINE_LEVEL=5 -DSOFTFLOAT_FAST_DIV32TO16 -DSOFTFLOAT_FAST_DIV64TO32 -DSOFTFLOAT_FAST_INT64  -DFLOAT16 -DFLOAT64 -DEXTFLOAT80 -DFLOAT128 -DFLOAT_ROUND_ODD -DLONG_DOUBLE_IS_EXTFLOAT80  -Wno-strict-prototypes -Wno-unknown-pragmas -Wno-uninitialized -Wno-missing-prototypes -Wno-return-type -Wno-unused-function -Wno-error -MMD -MP -MT writeCase_abc_f64.o -MF ./writeCase_abc_f64.d -fsanitize=undefined -fsanitize=address -g   -c -o writeCase_abc_f64.o /tmp/qemu-test/src/tests/fp/berkeley-testfloat-3/source/writeCase_abc_f64.c
/tmp/qemu-test/src/tests/test-util-filemonitor.c:449:45: error: incompatible pointer types passing 'void (int, QFileMonitorEvent, const char *, void *)' to parameter of type 'QFileMonitorHandler' (aka 'void (*)(long, QFileMonitorEvent, const char *, void *)') [-Werror,-Wincompatible-pointer-types]
                                            qemu_file_monitor_test_handler,
                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/qemu-test/src/include/qemu/filemonitor.h:109:57: note: passing argument to parameter 'cb' here


The full log is available at
http://patchew.org/logs/20190320174150.12067-1-berrange@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Daniel P. Berrangé March 21, 2019, 10:18 a.m. UTC | #2
Obviously NACK to applying this PULL given the patchew reported
mess up I did with tests.  Not sure why patchew never gave any
complaint when the original patch was posted & reviewed :-(

On Wed, Mar 20, 2019 at 05:41:47PM +0000, Daniel P. Berrangé wrote:
> The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2:
> 
>   Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +0000)
> 
> are available in the Git repository at:
> 
>   https://github.com/berrange/qemu tags/filemon-next-pull-request
> 
> for you to fetch changes up to 9c8cc692ccda6912e46a4b13c4bbcd42df3e8673:
> 
>   filemon: fix watch IDs to avoid potential wraparound issues (2019-03-20 17:03:29 +0000)
> 
> ----------------------------------------------------------------
> Fix watch uniqueness and protect against guest triggered
> integer wraparound clashes in watches.
> 
> ----------------------------------------------------------------
> 
> Daniel P. Berrangé (3):
>   tests: refactor file monitor test to make it more understandable
>   filemon: ensure watch IDs are unique to QFileMonitor scope
>   filemon: fix watch IDs to avoid potential wraparound issues
> 
>  authz/listfile.c              |   2 +-
>  hw/usb/dev-mtp.c              |  10 +-
>  include/authz/listfile.h      |   2 +-
>  include/qemu/filemonitor.h    |  16 +-
>  tests/test-util-filemonitor.c | 626 +++++++++++++++++-----------------
>  util/filemonitor-inotify.c    |  26 +-
>  util/filemonitor-stub.c       |   4 +-
>  util/trace-events             |   6 +-
>  8 files changed, 337 insertions(+), 355 deletions(-)
> 
> -- 
> 2.20.1
> 

Regards,
Daniel