[4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys
diff mbox series

Message ID 20190320201402.114309-4-dianders@chromium.org
State New
Headers show
Series
  • [1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288
Related show

Commit Message

Doug Anderson March 20, 2019, 8:14 p.m. UTC
They are pointless.  As dtc points out:
  Warning (avoid_unnecessary_addr_size):
  /gpio-keys:
  unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Let's remove them.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm/boot/dts/rk3288-veyron.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Matthias Kaehlcke March 21, 2019, 9:14 p.m. UTC | #1
On Wed, Mar 20, 2019 at 01:14:02PM -0700, Douglas Anderson wrote:
> They are pointless.  As dtc points out:
>   Warning (avoid_unnecessary_addr_size):
>   /gpio-keys:
>   unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Let's remove them.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> 
>  arch/arm/boot/dts/rk3288-veyron.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 0bc2409f6903..192dbc089ade 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -25,8 +25,6 @@
>  
>  	gpio_keys: gpio-keys {
>  		compatible = "gpio-keys";
> -		#address-cells = <1>;
> -		#size-cells = <0>;
>  
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pwr_key_l>;

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 0bc2409f6903..192dbc089ade 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -25,8 +25,6 @@ 
 
 	gpio_keys: gpio-keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&pwr_key_l>;