[i-g-t] lib: Add PCI IDs for Comet Lake
diff mbox series

Message ID 20190320220024.16075-1-anusha.srivatsa@intel.com
State New
Headers show
Series
  • [i-g-t] lib: Add PCI IDs for Comet Lake
Related show

Commit Message

Srivatsa, Anusha March 20, 2019, 10 p.m. UTC
From: Anusha Srivatsa <anusha.srivatsa@intel.com>

Sync PCI IDs with that of kernel.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 lib/i915_pciids.h       | 28 +++++++++++++++++++++++++++-
 lib/intel_device_info.c |  2 ++
 2 files changed, 29 insertions(+), 1 deletion(-)

Comments

Souza, Jose March 20, 2019, 10:26 p.m. UTC | #1
Please sync(copy) the whole file, there is other PCI id additions in
kernel that are missed in here, the same for your lib drm patch.

On Wed, 2019-03-20 at 15:00 -0700, Anusha wrote:
> From: Anusha Srivatsa <anusha.srivatsa@intel.com>
> 
> Sync PCI IDs with that of kernel.
> 
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  lib/i915_pciids.h       | 28 +++++++++++++++++++++++++++-
>  lib/intel_device_info.c |  2 ++
>  2 files changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 19266714..d0c8049c 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -369,6 +369,30 @@
>  	INTEL_VGA_DEVICE(0x591C, info),  /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
>  
> +/* CML GT1 */
> +#define INTEL_CML_GT1_IDS(info) \
> +	INTEL_VGA_DEVICE(0x9B21, info), \
> +	INTEL_VGA_DEVICE(0x9BAA, info), \
> +	INTEL_VGA_DEVICE(0x9BAB, info), \
> +	INTEL_VGA_DEVICE(0x9BAC, info), \
> +	INTEL_VGA_DEVICE(0x9BA0, info), \
> +	INTEL_VGA_DEVICE(0x9BA5, info), \
> +	INTEL_VGA_DEVICE(0x9BA8, info), \
> +	INTEL_VGA_DEVICE(0x9BA4, info), \
> +	INTEL_VGA_DEVICE(0x9BA2, info)
> +
> +/* CML GT2 */
> +#define INTEL_CML_GT2_IDS(info) \
> +	INTEL_VGA_DEVICE(0x9B41, info), \
> +	INTEL_VGA_DEVICE(0x9BCA, info), \
> +	INTEL_VGA_DEVICE(0x9BCB, info), \
> +	INTEL_VGA_DEVICE(0x9BCC, info), \
> +	INTEL_VGA_DEVICE(0x9BC0, info), \
> +	INTEL_VGA_DEVICE(0x9BC5, info), \
> +	INTEL_VGA_DEVICE(0x9BC8, info), \
> +	INTEL_VGA_DEVICE(0x9BC4, info), \
> +	INTEL_VGA_DEVICE(0x9BC2, info)
> +
>  /* AML/CFL Y GT2 */
>  #define INTEL_AML_CFL_GT2_IDS(info) \
>  	INTEL_VGA_DEVICE(0x87CA, info)
> @@ -432,7 +456,9 @@
>  	INTEL_WHL_U_GT1_IDS(info), \
>  	INTEL_WHL_U_GT2_IDS(info), \
>  	INTEL_WHL_U_GT3_IDS(info), \
> -	INTEL_AML_CFL_GT2_IDS(info)
> +	INTEL_AML_CFL_GT2_IDS(info), \
> +	INTEL_CML_GT1_IDS(info), \
> +	INTEL_CML_GT2_IDS(info)
>  
>  /* CNL */
>  #define INTEL_CNL_IDS(info) \
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 076168bf..8dbcf747 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -358,6 +358,8 @@ static const struct pci_id_match
> intel_device_match[] = {
>  	INTEL_WHL_U_GT2_IDS(&intel_coffeelake_gt2_info),
>  	INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
>  	INTEL_AML_CFL_GT2_IDS(&intel_coffeelake_gt2_info),
> +	INTEL_CML_GT1_IDS(&intel_coffeelake_gt1_info),
> +	INTEL_CML_GT2_IDS(&intel_coffeelake_gt2_info),
>  
>  	INTEL_CNL_IDS(&intel_cannonlake_info),
>
Lucas De Marchi March 21, 2019, 1:14 a.m. UTC | #2
On Wed, Mar 20, 2019 at 03:26:54PM -0700, Jose Souza wrote:
>Please sync(copy) the whole file, there is other PCI id additions in
>kernel that are missed in here, the same for your lib drm patch.

and the commit message should be that you are synchronizing the kernel
header. See e.g. b2920f54 ("lib: sync i915_pciids.h with kernel")


Lucas De Marchi


>
>On Wed, 2019-03-20 at 15:00 -0700, Anusha wrote:
>> From: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>
>> Sync PCI IDs with that of kernel.
>>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>>  lib/i915_pciids.h       | 28 +++++++++++++++++++++++++++-
>>  lib/intel_device_info.c |  2 ++
>>  2 files changed, 29 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
>> index 19266714..d0c8049c 100644
>> --- a/lib/i915_pciids.h
>> +++ b/lib/i915_pciids.h
>> @@ -369,6 +369,30 @@
>>  	INTEL_VGA_DEVICE(0x591C, info),  /* ULX GT2 */ \
>>  	INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
>>
>> +/* CML GT1 */
>> +#define INTEL_CML_GT1_IDS(info) \
>> +	INTEL_VGA_DEVICE(0x9B21, info), \
>> +	INTEL_VGA_DEVICE(0x9BAA, info), \
>> +	INTEL_VGA_DEVICE(0x9BAB, info), \
>> +	INTEL_VGA_DEVICE(0x9BAC, info), \
>> +	INTEL_VGA_DEVICE(0x9BA0, info), \
>> +	INTEL_VGA_DEVICE(0x9BA5, info), \
>> +	INTEL_VGA_DEVICE(0x9BA8, info), \
>> +	INTEL_VGA_DEVICE(0x9BA4, info), \
>> +	INTEL_VGA_DEVICE(0x9BA2, info)
>> +
>> +/* CML GT2 */
>> +#define INTEL_CML_GT2_IDS(info) \
>> +	INTEL_VGA_DEVICE(0x9B41, info), \
>> +	INTEL_VGA_DEVICE(0x9BCA, info), \
>> +	INTEL_VGA_DEVICE(0x9BCB, info), \
>> +	INTEL_VGA_DEVICE(0x9BCC, info), \
>> +	INTEL_VGA_DEVICE(0x9BC0, info), \
>> +	INTEL_VGA_DEVICE(0x9BC5, info), \
>> +	INTEL_VGA_DEVICE(0x9BC8, info), \
>> +	INTEL_VGA_DEVICE(0x9BC4, info), \
>> +	INTEL_VGA_DEVICE(0x9BC2, info)
>> +
>>  /* AML/CFL Y GT2 */
>>  #define INTEL_AML_CFL_GT2_IDS(info) \
>>  	INTEL_VGA_DEVICE(0x87CA, info)
>> @@ -432,7 +456,9 @@
>>  	INTEL_WHL_U_GT1_IDS(info), \
>>  	INTEL_WHL_U_GT2_IDS(info), \
>>  	INTEL_WHL_U_GT3_IDS(info), \
>> -	INTEL_AML_CFL_GT2_IDS(info)
>> +	INTEL_AML_CFL_GT2_IDS(info), \
>> +	INTEL_CML_GT1_IDS(info), \
>> +	INTEL_CML_GT2_IDS(info)
>>
>>  /* CNL */
>>  #define INTEL_CNL_IDS(info) \
>> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
>> index 076168bf..8dbcf747 100644
>> --- a/lib/intel_device_info.c
>> +++ b/lib/intel_device_info.c
>> @@ -358,6 +358,8 @@ static const struct pci_id_match
>> intel_device_match[] = {
>>  	INTEL_WHL_U_GT2_IDS(&intel_coffeelake_gt2_info),
>>  	INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
>>  	INTEL_AML_CFL_GT2_IDS(&intel_coffeelake_gt2_info),
>> +	INTEL_CML_GT1_IDS(&intel_coffeelake_gt1_info),
>> +	INTEL_CML_GT2_IDS(&intel_coffeelake_gt2_info),
>>
>>  	INTEL_CNL_IDS(&intel_cannonlake_info),
>>

Patch
diff mbox series

diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 19266714..d0c8049c 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -369,6 +369,30 @@ 
 	INTEL_VGA_DEVICE(0x591C, info),  /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
 
+/* CML GT1 */
+#define INTEL_CML_GT1_IDS(info) \
+	INTEL_VGA_DEVICE(0x9B21, info), \
+	INTEL_VGA_DEVICE(0x9BAA, info), \
+	INTEL_VGA_DEVICE(0x9BAB, info), \
+	INTEL_VGA_DEVICE(0x9BAC, info), \
+	INTEL_VGA_DEVICE(0x9BA0, info), \
+	INTEL_VGA_DEVICE(0x9BA5, info), \
+	INTEL_VGA_DEVICE(0x9BA8, info), \
+	INTEL_VGA_DEVICE(0x9BA4, info), \
+	INTEL_VGA_DEVICE(0x9BA2, info)
+
+/* CML GT2 */
+#define INTEL_CML_GT2_IDS(info) \
+	INTEL_VGA_DEVICE(0x9B41, info), \
+	INTEL_VGA_DEVICE(0x9BCA, info), \
+	INTEL_VGA_DEVICE(0x9BCB, info), \
+	INTEL_VGA_DEVICE(0x9BCC, info), \
+	INTEL_VGA_DEVICE(0x9BC0, info), \
+	INTEL_VGA_DEVICE(0x9BC5, info), \
+	INTEL_VGA_DEVICE(0x9BC8, info), \
+	INTEL_VGA_DEVICE(0x9BC4, info), \
+	INTEL_VGA_DEVICE(0x9BC2, info)
+
 /* AML/CFL Y GT2 */
 #define INTEL_AML_CFL_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x87CA, info)
@@ -432,7 +456,9 @@ 
 	INTEL_WHL_U_GT1_IDS(info), \
 	INTEL_WHL_U_GT2_IDS(info), \
 	INTEL_WHL_U_GT3_IDS(info), \
-	INTEL_AML_CFL_GT2_IDS(info)
+	INTEL_AML_CFL_GT2_IDS(info), \
+	INTEL_CML_GT1_IDS(info), \
+	INTEL_CML_GT2_IDS(info)
 
 /* CNL */
 #define INTEL_CNL_IDS(info) \
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 076168bf..8dbcf747 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -358,6 +358,8 @@  static const struct pci_id_match intel_device_match[] = {
 	INTEL_WHL_U_GT2_IDS(&intel_coffeelake_gt2_info),
 	INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
 	INTEL_AML_CFL_GT2_IDS(&intel_coffeelake_gt2_info),
+	INTEL_CML_GT1_IDS(&intel_coffeelake_gt1_info),
+	INTEL_CML_GT2_IDS(&intel_coffeelake_gt2_info),
 
 	INTEL_CNL_IDS(&intel_cannonlake_info),