diff mbox series

[-next] scsi: ufs-mediatek: Fix platform_no_drv_owner.cocci warnings

Message ID 20190321014517.11552-1-yuehaibing@huawei.com (mailing list archive)
State Mainlined
Commit 3aa222cdfc2c90b97539e8f4e70a4aec0b1258a6
Headers show
Series [-next] scsi: ufs-mediatek: Fix platform_no_drv_owner.cocci warnings | expand

Commit Message

Yue Haibing March 21, 2019, 1:45 a.m. UTC
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/scsi/ufs/ufs-mediatek.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Stanley Chu March 21, 2019, 6:07 a.m. UTC | #1
Hi,

On Thu, 2019-03-21 at 01:45 +0000, YueHaibing wrote:
> Remove .owner field if calls are used which set it automatically
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/scsi/ufs/ufs-mediatek.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc83d3f..e9590bff5b5c 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -358,7 +358,6 @@ static struct platform_driver ufs_mtk_pltform = {
>  	.shutdown   = ufshcd_pltfrm_shutdown,
>  	.driver = {
>  		.name   = "ufshcd-mtk",
> -		.owner  = THIS_MODULE,
>  		.pm     = &ufs_mtk_pm_ops,
>  		.of_match_table = ufs_mtk_of_match,
>  	},
> 
> 
This is redundant currently. Thanks for helping removing it.

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>


Thanks,
Stanley
Martin K. Petersen March 26, 2019, 2:07 a.m. UTC | #2
YueHaibing,

> Remove .owner field if calls are used which set it automatically
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Applied to 5.2/scsi-queue, thanks.
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index c3b78fc83d3f..e9590bff5b5c 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -358,7 +358,6 @@  static struct platform_driver ufs_mtk_pltform = {
 	.shutdown   = ufshcd_pltfrm_shutdown,
 	.driver = {
 		.name   = "ufshcd-mtk",
-		.owner  = THIS_MODULE,
 		.pm     = &ufs_mtk_pm_ops,
 		.of_match_table = ufs_mtk_of_match,
 	},