| Message ID | 1553202928-34824-3-git-send-email-vladimir.petrigo@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: adc: Fix code formatting issues | expand |
On Fri, 22 Mar 2019 00:15:28 +0300 Vladimir Petrigo <vladimir.petrigo@gmail.com> wrote: > - Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid precedence issues > > Signed-off-by: Vladimir Petrigo <vladimir.petrigo@gmail.com> Hi Vladimir, This particular driver has recently moved out of staging and gained support for some additional parts. Still the particular issue was there still. I applied your patch by hand to the moved driver and the additional case of the same thing that was write next to this. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7780.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c > index c4a8578..010fb47 100644 > --- a/drivers/staging/iio/adc/ad7780.c > +++ b/drivers/staging/iio/adc/ad7780.c > @@ -142,7 +142,7 @@ static const struct ad_sigma_delta_info ad7780_sigma_delta_info = { > }; > > #define AD7780_CHANNEL(bits, wordsize) \ > - AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, wordsize - bits) > + AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, (wordsize) - (bits)) > > static const struct ad7780_chip_info ad7780_chip_info_tbl[] = { > [ID_AD7170] = {
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c index c4a8578..010fb47 100644 --- a/drivers/staging/iio/adc/ad7780.c +++ b/drivers/staging/iio/adc/ad7780.c @@ -142,7 +142,7 @@ static const struct ad_sigma_delta_info ad7780_sigma_delta_info = { }; #define AD7780_CHANNEL(bits, wordsize) \ - AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, wordsize - bits) + AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, (wordsize) - (bits)) static const struct ad7780_chip_info ad7780_chip_info_tbl[] = { [ID_AD7170] = {
- Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid precedence issues Signed-off-by: Vladimir Petrigo <vladimir.petrigo@gmail.com> --- drivers/staging/iio/adc/ad7780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)