| Message ID | 1553218974-20464-2-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add i.MX7ULP EVK PWM backlight support | expand |
On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote: > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > No changes. v9? I don't recall seeing any previous versions. > --- > .../devicetree/bindings/pwm/imx-tpm-pwm.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > new file mode 100644 > index 0000000..94f1ad5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > @@ -0,0 +1,22 @@ > +Freescale i.MX TPM PWM controller > + > +Required properties: > +- compatible : Should be "fsl,imx-tpm". Needs to be SoC specific. > +- reg: Physical base address and length of the controller's registers. > +- #pwm-cells: Should be 3. See pwm.txt in this directory for a description of the cells format. > +- clocks : The clock provided by the SoC to drive the PWM. > +- interrupts: The interrupt for the PWM controller. > + > +Note: The TPM counter and period counter are shared between multiple channels, so all channels > +should use same period setting. > + > +Example: > + > +pwm0: tpm@40250000 { pwm@...
On Mon, Mar 25, 2019 at 03:41:37PM -0500, Rob Herring wrote: > On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote: > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > No changes. > > v9? I don't recall seeing any previous versions. Not sure it actually matters, but you were on Cc: for v7 and v8 at least: https://www.spinics.net/lists/linux-pwm/msg09300.html https://www.spinics.net/lists/linux-pwm/msg09321.html Best regards Uwe
Hi, Rob Best Regards! Anson Huang > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 2019年3月26日 4:42 > To: Anson Huang <anson.huang@nxp.com> > Cc: thierry.reding@gmail.com; mark.rutland@arm.com; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch; > otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>; > Robin Gong <yibin.gong@nxp.com>; jan.tuerk@emtrion.com; linux- > pwm@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine- > koenig@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding > > On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote: > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM > binding. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > No changes. > > v9? I don't recall seeing any previous versions. I checked my mailbox, you are in the "to" list in every version. The first version's subject is: [PATCH 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding... > > > --- > > .../devicetree/bindings/pwm/imx-tpm-pwm.txt | 22 > ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > new file mode 100644 > > index 0000000..94f1ad5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > @@ -0,0 +1,22 @@ > > +Freescale i.MX TPM PWM controller > > + > > +Required properties: > > +- compatible : Should be "fsl,imx-tpm". > > Needs to be SoC specific. OK, will change it to "fsl,imx7ulp-tpm" in next verson. > > > +- reg: Physical base address and length of the controller's registers. > > +- #pwm-cells: Should be 3. See pwm.txt in this directory for a description > of the cells format. > > +- clocks : The clock provided by the SoC to drive the PWM. > > +- interrupts: The interrupt for the PWM controller. > > + > > +Note: The TPM counter and period counter are shared between multiple > > +channels, so all channels should use same period setting. > > + > > +Example: > > + > > +pwm0: tpm@40250000 { > > pwm@... I forgot to update the example in DT binding, sorry for that, will update it according to below dts node: pwm0: pwm@40250000 { Anson.
Hi, Rob Best Regards! Anson Huang > -----Original Message----- > From: Anson Huang > Sent: 2019年3月26日 8:56 > To: 'Rob Herring' <robh@kernel.org> > Cc: thierry.reding@gmail.com; mark.rutland@arm.com; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch; > otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>; > Robin Gong <yibin.gong@nxp.com>; jan.tuerk@emtrion.com; linux- > pwm@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine- > koenig@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding > > Hi, Rob > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: 2019年3月26日 4:42 > > To: Anson Huang <anson.huang@nxp.com> > > Cc: thierry.reding@gmail.com; mark.rutland@arm.com; > > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > > festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch; > > otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>; > > Robin Gong <yibin.gong@nxp.com>; jan.tuerk@emtrion.com; linux- > > pwm@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine- > > koenig@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH V9 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding > > > > On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote: > > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM > > binding. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > No changes. > > > > v9? I don't recall seeing any previous versions. > > I checked my mailbox, you are in the "to" list in every version. The first > version's subject is: > [PATCH 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding... > > > > > > --- > > > .../devicetree/bindings/pwm/imx-tpm-pwm.txt | 22 > > ++++++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > new file mode 100644 > > > index 0000000..94f1ad5 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > @@ -0,0 +1,22 @@ > > > +Freescale i.MX TPM PWM controller > > > + > > > +Required properties: > > > +- compatible : Should be "fsl,imx-tpm". > > > > Needs to be SoC specific. > > OK, will change it to "fsl,imx7ulp-tpm" in next verson. As " fsl,imx7ulp-tpm " is already used for timer, TPM can work as a timer or PWM, so I have to use " fsl,imx7ulp-pwm" in the V10 patch I just sent. Anson. > > > > > > +- reg: Physical base address and length of the controller's registers. > > > +- #pwm-cells: Should be 3. See pwm.txt in this directory for a > > > +description > > of the cells format. > > > +- clocks : The clock provided by the SoC to drive the PWM. > > > +- interrupts: The interrupt for the PWM controller. > > > + > > > +Note: The TPM counter and period counter are shared between > > > +multiple channels, so all channels should use same period setting. > > > + > > > +Example: > > > + > > > +pwm0: tpm@40250000 { > > > > pwm@... > > I forgot to update the example in DT binding, sorry for that, will update it > according to below dts node: > > pwm0: pwm@40250000 { > > Anson.
On Mon, Mar 25, 2019 at 3:59 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > On Mon, Mar 25, 2019 at 03:41:37PM -0500, Rob Herring wrote: > > On Fri, Mar 22, 2019 at 01:48:05AM +0000, Anson Huang wrote: > > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > No changes. > > > > v9? I don't recall seeing any previous versions. > > Not sure it actually matters, but you were on Cc: for v7 and v8 at > least: > > https://www.spinics.net/lists/linux-pwm/msg09300.html > https://www.spinics.net/lists/linux-pwm/msg09321.html 10 versions now in 2 weeks is why. Reviewers do get busy and/or go on vacation. Please slow down your pace and give people time to review. Rob
diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt new file mode 100644 index 0000000..94f1ad5 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt @@ -0,0 +1,22 @@ +Freescale i.MX TPM PWM controller + +Required properties: +- compatible : Should be "fsl,imx-tpm". +- reg: Physical base address and length of the controller's registers. +- #pwm-cells: Should be 3. See pwm.txt in this directory for a description of the cells format. +- clocks : The clock provided by the SoC to drive the PWM. +- interrupts: The interrupt for the PWM controller. + +Note: The TPM counter and period counter are shared between multiple channels, so all channels +should use same period setting. + +Example: + +pwm0: tpm@40250000 { + compatible = "fsl,imx-tpm"; + reg = <0x40250000 0x1000>; + assigned-clocks = <&clks IMX7ULP_CLK_LPTPM4>; + assigned-clock-parents = <&clks IMX7ULP_CLK_SOSC_BUS_CLK>; + clocks = <&clks IMX7ULP_CLK_LPTPM4>; + #pwm-cells = <3>; +};
Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- No changes. --- .../devicetree/bindings/pwm/imx-tpm-pwm.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt