| Message ID | 20190322113808.16858-2-christoph.muellner@theobroma-systems.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/3] dt-bindings: mmc: Add disable-cqe-dcmd property. | expand |
On Fri, 22 Mar 2019 at 12:39, Christoph Muellner <christoph.muellner@theobroma-systems.com> wrote: > > Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > which exposes a control register bit to enable the feature. > The current implementation sets this bit unconditionally. > > This patch allows to suppress the feature activation, > by specifying the property disable-cqe-dcmd. > > Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Acked-by: Adrian Hunter <adrian.hunter@intel.com> Applied for next, thanks! Perhaps both patch1 and patch2 should be tagged for stable? Then please tell me and I can add a tag. Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index c9e3e050ccc8..88dc3f00a5be 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev) > host->mmc_host_ops.start_signal_voltage_switch = > sdhci_arasan_voltage_switch; > sdhci_arasan->has_cqe = true; > - host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; > + host->mmc->caps2 |= MMC_CAP2_CQE; > + > + if (!of_property_read_bool(np, "disable-cqe-dcmd")) > + host->mmc->caps2 |= MMC_CAP2_CQE_DCMD; > } > > ret = sdhci_arasan_add_host(sdhci_arasan); > -- > 2.11.0 >
> On 25.03.2019, at 14:27, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Fri, 22 Mar 2019 at 12:39, Christoph Muellner > <christoph.muellner@theobroma-systems.com> wrote: >> >> Direct commands (DCMDs) are an optional feature of eMMC 5.1's command >> queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, >> which exposes a control register bit to enable the feature. >> The current implementation sets this bit unconditionally. >> >> This patch allows to suppress the feature activation, >> by specifying the property disable-cqe-dcmd. >> >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > > Applied for next, thanks! > > Perhaps both patch1 and patch2 should be tagged for stable? Then > please tell me and I can add a tag. Hi Ulf, yes tagging for stable would be nice. I guess, the following would fit: Fixes: 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1") Thanks, Christoph > > Kind regards > Uffe > > > >> --- >> drivers/mmc/host/sdhci-of-arasan.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c >> index c9e3e050ccc8..88dc3f00a5be 100644 >> --- a/drivers/mmc/host/sdhci-of-arasan.c >> +++ b/drivers/mmc/host/sdhci-of-arasan.c >> @@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev) >> host->mmc_host_ops.start_signal_voltage_switch = >> sdhci_arasan_voltage_switch; >> sdhci_arasan->has_cqe = true; >> - host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; >> + host->mmc->caps2 |= MMC_CAP2_CQE; >> + >> + if (!of_property_read_bool(np, "disable-cqe-dcmd")) >> + host->mmc->caps2 |= MMC_CAP2_CQE_DCMD; >> } >> >> ret = sdhci_arasan_add_host(sdhci_arasan); >> -- >> 2.11.0 >>
On Mon, 25 Mar 2019 at 14:39, Christoph Müllner <christoph.muellner@theobroma-systems.com> wrote: > > > > On 25.03.2019, at 14:27, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Fri, 22 Mar 2019 at 12:39, Christoph Muellner > > <christoph.muellner@theobroma-systems.com> wrote: > >> > >> Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > >> queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > >> which exposes a control register bit to enable the feature. > >> The current implementation sets this bit unconditionally. > >> > >> This patch allows to suppress the feature activation, > >> by specifying the property disable-cqe-dcmd. > >> > >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > >> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > > > > Applied for next, thanks! > > > > Perhaps both patch1 and patch2 should be tagged for stable? Then > > please tell me and I can add a tag. > > Hi Ulf, > > yes tagging for stable would be nice. > I guess, the following would fit: > > Fixes: 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1") > Great, I have added that to both of the commits and a stable tag. Thanks! [...] Kind regards Uffe
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index c9e3e050ccc8..88dc3f00a5be 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev) host->mmc_host_ops.start_signal_voltage_switch = sdhci_arasan_voltage_switch; sdhci_arasan->has_cqe = true; - host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; + host->mmc->caps2 |= MMC_CAP2_CQE; + + if (!of_property_read_bool(np, "disable-cqe-dcmd")) + host->mmc->caps2 |= MMC_CAP2_CQE_DCMD; } ret = sdhci_arasan_add_host(sdhci_arasan);