| Message ID | 20190322163059.9716-1-drjones@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/arm: default config | expand |
On 22/03/2019 17.30, Andrew Jones wrote: > In the kconfig shuffle arm lost pci-testdev which is used by > kvm-unit-tests. Let's add it back. ... the other architectures use "imply TEST_DEVICES" in the Kconfig files, but since the Kconfig-for-arm patches have not included before the hard-freeze, your patch here is likely the better work-around for 4.0. Reviewed-by: Thomas Huth <thuth@redhat.com>
On Fri, 22 Mar 2019 at 16:31, Andrew Jones <drjones@redhat.com> wrote: > > In the kconfig shuffle arm lost pci-testdev which is used by > kvm-unit-tests. Let's add it back. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > default-configs/arm-softmmu.mak | 1 + Applied to target-arm.next (with a tweaked subject line), thanks. -- PMM
On 22/03/19 17:30, Andrew Jones wrote: > In the kconfig shuffle arm lost pci-testdev which is used by > kvm-unit-tests. Let's add it back. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > default-configs/arm-softmmu.mak | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 2a7efc11674a..613d19a06db2 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -2,6 +2,7 @@ > > CONFIG_PCI=y > CONFIG_PCI_DEVICES=y > +CONFIG_PCI_TESTDEV=y > CONFIG_VGA=y > CONFIG_NAND=y > CONFIG_ECC=y > -- Let's add all of CONFIG_TEST_DEVICES instead. Paolo
On 25/03/19 10:49, Peter Maydell wrote: > On Fri, 22 Mar 2019 at 16:31, Andrew Jones <drjones@redhat.com> wrote: >> >> In the kconfig shuffle arm lost pci-testdev which is used by >> kvm-unit-tests. Let's add it back. >> >> Signed-off-by: Andrew Jones <drjones@redhat.com> >> --- >> default-configs/arm-softmmu.mak | 1 + > > > > Applied to target-arm.next (with a tweaked subject line), thanks. Sounds good, and safer than CONFIG_TEST_DEVICES for 4.0 so I'm okay with your call! Thanks, Paolo
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index 2a7efc11674a..613d19a06db2 100644 --- a/default-configs/arm-softmmu.mak +++ b/default-configs/arm-softmmu.mak @@ -2,6 +2,7 @@ CONFIG_PCI=y CONFIG_PCI_DEVICES=y +CONFIG_PCI_TESTDEV=y CONFIG_VGA=y CONFIG_NAND=y CONFIG_ECC=y
In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back. Signed-off-by: Andrew Jones <drjones@redhat.com> --- default-configs/arm-softmmu.mak | 1 + 1 file changed, 1 insertion(+)