diff mbox series

[2/2] drm/i915: Use vblank_disable_immediate on gen2

Message ID 20190322180804.3300-2-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915: Disable C3 when enabling vblank interrupts on i945gm | expand

Commit Message

Ville Syrjala March 22, 2019, 6:08 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The vblank timestamp->counter guesstimator seems to be
working sufficiently well, so there's no reason not to
disable vblank interrupts ASAP even on gen2.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

Comments

Chris Wilson March 22, 2019, 9:09 p.m. UTC | #1 
Quoting Ville Syrjala (2019-03-22 18:08:04)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The vblank timestamp->counter guesstimator seems to be
> working sufficiently well, so there's no reason not to
> disable vblank interrupts ASAP even on gen2.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 33386f0acab3..a5aff4de5fb0 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -4642,13 +4642,7 @@  void intel_irq_init(struct drm_i915_private *dev_priv)
 	else if (INTEL_GEN(dev_priv) >= 3)
 		dev->driver->get_vblank_counter = i915_get_vblank_counter;
 
-	/*
-	 * Opt out of the vblank disable timer on everything except gen2.
-	 * Gen2 doesn't have a hardware frame counter and so depends on
-	 * vblank interrupts to produce sane vblank seuquence numbers.
-	 */
-	if (!IS_GEN(dev_priv, 2))
-		dev->vblank_disable_immediate = true;
+	dev->vblank_disable_immediate = true;
 
 	/* Most platforms treat the display irq block as an always-on
 	 * power domain. vlv/chv can disable it at runtime and need