| Message ID | 1553296835-37522-4-git-send-email-parav@mellanox.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio/mdev: Improve vfio/mdev core module | expand |
On Fri, 2019-03-22 at 18:20 -0500, Parav Pandit wrote: > Remove unused kref from the mdev_device structure. > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > drivers/vfio/mdev/mdev_core.c | 1 - > drivers/vfio/mdev/mdev_private.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 4f213e4d..3d91f62 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -311,7 +311,6 @@ int mdev_device_create(struct kobject *kobj, struct device > *dev, uuid_le uuid) > mutex_unlock(&mdev_list_lock); > > mdev->parent = parent; > - kref_init(&mdev->ref); > > mdev->dev.parent = dev; > mdev->dev.bus = &mdev_bus_type; > diff --git a/drivers/vfio/mdev/mdev_private.h > b/drivers/vfio/mdev/mdev_private.h > index b5819b7..84b2b6c 100644 > --- a/drivers/vfio/mdev/mdev_private.h > +++ b/drivers/vfio/mdev/mdev_private.h > @@ -30,7 +30,6 @@ struct mdev_device { > struct mdev_parent *parent; > uuid_le uuid; > void *driver_data; > - struct kref ref; > struct list_head next; > struct kobject *type_kobj; > bool active; When develping my nvme-mdev driver, I'll seen that unused kref too. Dead code has to go. Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com> Best regards, Maxim Levitsky
On 3/23/2019 4:50 AM, Parav Pandit wrote: > Remove unused kref from the mdev_device structure. > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > drivers/vfio/mdev/mdev_core.c | 1 - > drivers/vfio/mdev/mdev_private.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 4f213e4d..3d91f62 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -311,7 +311,6 @@ int mdev_device_create(struct kobject *kobj, struct device *dev, uuid_le uuid) > mutex_unlock(&mdev_list_lock); > > mdev->parent = parent; > - kref_init(&mdev->ref); > > mdev->dev.parent = dev; > mdev->dev.bus = &mdev_bus_type; > diff --git a/drivers/vfio/mdev/mdev_private.h b/drivers/vfio/mdev/mdev_private.h > index b5819b7..84b2b6c 100644 > --- a/drivers/vfio/mdev/mdev_private.h > +++ b/drivers/vfio/mdev/mdev_private.h > @@ -30,7 +30,6 @@ struct mdev_device { > struct mdev_parent *parent; > uuid_le uuid; > void *driver_data; > - struct kref ref; > struct list_head next; > struct kobject *type_kobj; > bool active; > Yes, this should be removed. Reviewed By: Kirti Wankhede <kwankhede@nvidia.com> Thanks, Kirti
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c index 4f213e4d..3d91f62 100644 --- a/drivers/vfio/mdev/mdev_core.c +++ b/drivers/vfio/mdev/mdev_core.c @@ -311,7 +311,6 @@ int mdev_device_create(struct kobject *kobj, struct device *dev, uuid_le uuid) mutex_unlock(&mdev_list_lock); mdev->parent = parent; - kref_init(&mdev->ref); mdev->dev.parent = dev; mdev->dev.bus = &mdev_bus_type; diff --git a/drivers/vfio/mdev/mdev_private.h b/drivers/vfio/mdev/mdev_private.h index b5819b7..84b2b6c 100644 --- a/drivers/vfio/mdev/mdev_private.h +++ b/drivers/vfio/mdev/mdev_private.h @@ -30,7 +30,6 @@ struct mdev_device { struct mdev_parent *parent; uuid_le uuid; void *driver_data; - struct kref ref; struct list_head next; struct kobject *type_kobj; bool active;
Remove unused kref from the mdev_device structure. Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") Signed-off-by: Parav Pandit <parav@mellanox.com> --- drivers/vfio/mdev/mdev_core.c | 1 - drivers/vfio/mdev/mdev_private.h | 1 - 2 files changed, 2 deletions(-)