[-next] ASoC: simple-card-utils: remove set but not used variable ''
diff mbox series

Message ID 20190323020838.107533-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] ASoC: simple-card-utils: remove set but not used variable ''
Related show

Commit Message

YueHaibing March 23, 2019, 2:08 a.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
sound/soc/generic/simple-card-utils.c:164:18: warning:
 parameter 'dai_name' set but not used [-Wunused-but-set-parameter]

It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
asoc_simple_debug_info()"), so can be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 sound/soc/generic/simple-card-utils.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Kuninori Morimoto March 25, 2019, 2:31 a.m. UTC | #1
Hi

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
> sound/soc/generic/simple-card-utils.c:164:18: warning:
>  parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
> 
> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
> asoc_simple_debug_info()"), so can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

I think dai_name parameter itself is no longer needed for this function,
but, it will be removed if all driver switched to modern dai_link style.
So, it is not a big deal.

	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Best regards
---
Kuninori Morimoto
YueHaibing March 25, 2019, 3:03 a.m. UTC | #2
On 2019/3/25 10:31, Kuninori Morimoto wrote:
> 
> Hi
> 
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>>  parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
> 
> I think dai_name parameter itself is no longer needed for this function,
> but, it will be removed if all driver switched to modern dai_link style.
> So, it is not a big deal.
> 
> 	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks, yes, this just a code cleanup.

> 
> Best regards
> ---
> Kuninori Morimoto
> 
> .
>
Mukesh Ojha March 25, 2019, 7:42 a.m. UTC | #3
On 3/23/2019 7:38 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
> sound/soc/generic/simple-card-utils.c:164:18: warning:
>   parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>
> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add


I am not able to find this commit

0580dde59438


> asoc_simple_debug_info()"), so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   sound/soc/generic/simple-card-utils.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index 4ed68348f939..db1458a19985 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>   	 * see
>   	 *	soc-core.c :: snd_soc_init_multicodec()
>   	 */
> -	if (dlc) {
> +	if (dlc)
>   		dai_of_node	= dlc->of_node;
> -		dai_name	= dlc->dai_name;

I don't see any function like `asoc_simple_parse_clk`

but instead this `asoc_simple_card_parse_clk` and there the variable is 
used.

Can you double check latest code base ?

Thanks,
Mukesh


> -	}
>   
>   	/*
>   	 * Parse dai->sysclk come from "clocks = <&xxx>"
>
>
>
>
>
YueHaibing March 25, 2019, 7:58 a.m. UTC | #4
On 2019/3/25 15:42, Mukesh Ojha wrote:
> 
> On 3/23/2019 7:38 AM, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>>   parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
> 
> 
> I am not able to find this commit
> 
> 0580dde59438

It's now in linux-next tree.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0580dde59438686d60762b6da9229ebec693b94f

> 
> 
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>   sound/soc/generic/simple-card-utils.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
>> index 4ed68348f939..db1458a19985 100644
>> --- a/sound/soc/generic/simple-card-utils.c
>> +++ b/sound/soc/generic/simple-card-utils.c
>> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>>        * see
>>        *    soc-core.c :: snd_soc_init_multicodec()
>>        */
>> -    if (dlc) {
>> +    if (dlc)
>>           dai_of_node    = dlc->of_node;
>> -        dai_name    = dlc->dai_name;
> 
> I don't see any function like `asoc_simple_parse_clk`
> 
> but instead this `asoc_simple_card_parse_clk` and there the variable is used.
> 
> Can you double check latest code base ?
> 
> Thanks,
> Mukesh
> 
> 
>> -    }
>>         /*
>>        * Parse dai->sysclk come from "clocks = <&xxx>"
>>
>>
>>
>>
>>
> 
> .
>
Mukesh Ojha March 25, 2019, 9:20 a.m. UTC | #5
On 3/25/2019 1:28 PM, YueHaibing wrote:
> On 2019/3/25 15:42, Mukesh Ojha wrote:
>> On 3/23/2019 7:38 AM, YueHaibing wrote:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>>>    parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>>
>>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>>
>> I am not able to find this commit
>>
>> 0580dde59438
> It's now in linux-next tree.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0580dde59438686d60762b6da9229ebec693b94f


I see the print is removed, dai_name becomes ununsed variable.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org 
<mailto:mojha@codeaurora.org>>

Thanks.
Mukesh


>>
>>> asoc_simple_debug_info()"), so can be removed.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>>    sound/soc/generic/simple-card-utils.c | 4 +---
>>>    1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
>>> index 4ed68348f939..db1458a19985 100644
>>> --- a/sound/soc/generic/simple-card-utils.c
>>> +++ b/sound/soc/generic/simple-card-utils.c
>>> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>>>         * see
>>>         *    soc-core.c :: snd_soc_init_multicodec()
>>>         */
>>> -    if (dlc) {
>>> +    if (dlc)
>>>            dai_of_node    = dlc->of_node;
>>> -        dai_name    = dlc->dai_name;
>> I don't see any function like `asoc_simple_parse_clk`
>>
>> but instead this `asoc_simple_card_parse_clk` and there the variable is used.
>>
>> Can you double check latest code base ?
>>
>> Thanks,
>> Mukesh
>>
>>
>>> -    }
>>>          /*
>>>         * Parse dai->sysclk come from "clocks = <&xxx>"
>>>
>>>
>>>
>>>
>>>
>> .
>>

Patch
diff mbox series

diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index 4ed68348f939..db1458a19985 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -173,10 +173,8 @@  int asoc_simple_parse_clk(struct device *dev,
 	 * see
 	 *	soc-core.c :: snd_soc_init_multicodec()
 	 */
-	if (dlc) {
+	if (dlc)
 		dai_of_node	= dlc->of_node;
-		dai_name	= dlc->dai_name;
-	}
 
 	/*
 	 * Parse dai->sysclk come from "clocks = <&xxx>"