From patchwork Fri Mar 22 03:28:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10867671 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 058911390 for ; Sun, 24 Mar 2019 21:02:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E73B328CE0 for ; Sun, 24 Mar 2019 21:02:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DBE6128E37; Sun, 24 Mar 2019 21:02:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 913E528CE0 for ; Sun, 24 Mar 2019 21:02:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74F596E58F; Sun, 24 Mar 2019 21:02:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E0016E230 for ; Fri, 22 Mar 2019 03:29:19 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id y3so477403pgk.12 for ; Thu, 21 Mar 2019 20:29:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VOc/5yQCsAvD8OjvVz+n50OZOgpX7N3tx64piXBEesg=; b=q2dI2IzBOuW9C1SAkknDAd1AV2t2HiuoA1hxFGqJY8oosxMLmiG5tLBZrsq8sH4M3L uc/4YKtlcxGM/jCPQFybL0qP/E6wCo42SSRC+heN5PyURBHEiK/ooyOL4UG1Z5ZHBfKt 8xdgQP1s/A1r6oRDF9uKs+96JOJVaMeLeYPj3n1H7wkmB1kngRFCAnyYLi1V2RTzdQeM 4aRbn6m7r1rWDTGmBfxABG4Nxw+JjeuOSU9/zlr3co1GNfVNQO1kNnvV1UY+bZ4RucZk pX9FS81ZGBYh8t518cMyBAgxmliF8ItFIMDtpYHcvwtnNseWgoJCAu2o22xkpcaJF4Oz HSaQ== X-Gm-Message-State: APjAAAWNz1fZh4+FV//yq67G/OBdFY7kqx6/EjOM2O+YIv6ibrg0Df4K zEg3vz39tpXJZI8NCW1RQsH1EDslSf0= X-Google-Smtp-Source: APXvYqycK7iLScZNxNVOYrFkda9YdoAMbf6K2CLIpZNjv6EPTe8sUbWc+PaMWEhMZsRvDLcH1BGKew== X-Received: by 2002:a63:3fc8:: with SMTP id m191mr6722072pga.240.1553225358146; Thu, 21 Mar 2019 20:29:18 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id o76sm16154476pfa.156.2019.03.21.20.29.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 20:29:17 -0700 (PDT) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 03/15] drm/bridge: tc358767: Simplify polling in tc_link_training() Date: Thu, 21 Mar 2019 20:28:49 -0700 Message-Id: <20190322032901.12045-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190322032901.12045-1-andrew.smirnov@gmail.com> References: <20190322032901.12045-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 24 Mar 2019 21:01:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VOc/5yQCsAvD8OjvVz+n50OZOgpX7N3tx64piXBEesg=; b=Blt/HSdUEH/v/5vwEHd0IJzvLpi/M1PDMXkn2f7n8RlRDaNJWV831F5ZTdLWbV3vht +OvDDJvJ1fNEL+EjA72VCRVDJKxu83PhwTkISn0rz3kYexr1U9mO8u9DOICOFlzHoTzW qJNw3M2q/NB17jWf2tyWD0+8vTkMS1iv/a45bySuESh56NXi8ORjUHZF0/CUOAao9GrG MtQcUQtAGAqZMaA2zBcExydLq53LiVcftw8w32+nS0PWQ6ZENXKtG4YFYiOCNkRXG8tw 991GwJP4UJU7ifsDFsy1dsmzNZnNg5zhGhalD9Nhk2L4Uif905ZO9QVFZnzuHWcitn0r 8o6Q== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Andrey Gusakov , linux-kernel@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , Chris Healy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Replace explicit polling in tc_link_training() with equivalent call to tc_poll_timeout() for simplicity. No functional change intended (not including slightly altered debug output). Signed-off-by: Andrey Smirnov Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Tomi Valkeinen Cc: Andrey Gusakov Cc: Philipp Zabel Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 2531f4dadbf8..38d542f553cd 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -733,21 +733,18 @@ static int tc_set_video_mode(struct tc_data *tc, struct drm_display_mode *mode) static int tc_wait_link_training(struct tc_data *tc, u32 *error) { - u32 timeout = 1000; u32 value; int ret; - do { - udelay(1); - tc_read(DP0_LTSTAT, &value); - } while ((!(value & LT_LOOPDONE)) && (--timeout)); - - if (timeout == 0) { + ret = tc_poll_timeout(tc, DP0_LTSTAT, LT_LOOPDONE, + LT_LOOPDONE, 1, 1000); + if (ret) { dev_err(tc->dev, "Link training timeout waiting for LT_LOOPDONE!\n"); - ret = -ETIMEDOUT; goto err; } + tc_read(DP0_LTSTAT, &value); + *error = (value >> 8) & 0x7; return 0;