| Message ID | 20190326055726.10539-1-richardw.yang@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | migration: remove not used field xfer_limit | expand |
* Wei Yang (richardw.yang@linux.intel.com) wrote: > MigrationState->xfer_limit is only set to 0 in migrate_init(). > > Remove this unnecessary field. > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Nice; I think that field has been unneeded since 1964a397063967 just over 5 years ago :-) Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/migration.c | 1 - > migration/migration.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index e88acab53b..533c2102c7 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) > * locks. > */ > s->bytes_xfer = 0; > - s->xfer_limit = 0; > s->cleanup_bh = 0; > s->to_dst_file = NULL; > s->rp_state.from_dst_file = NULL; > diff --git a/migration/migration.h b/migration/migration.h > index 99e99e56bd..852eb3c4e9 100644 > --- a/migration/migration.h > +++ b/migration/migration.h > @@ -117,7 +117,6 @@ struct MigrationState > > /*< public >*/ > size_t bytes_xfer; > - size_t xfer_limit; > QemuThread thread; > QEMUBH *cleanup_bh; > QEMUFile *to_dst_file; > -- > 2.19.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> Remove this unnecessary field. >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > >Nice; I think that field has been unneeded since 1964a397063967 >just over 5 years ago :-) > Wow, such a long time... > >Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > Thanks >> --- >> migration/migration.c | 1 - >> migration/migration.h | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index e88acab53b..533c2102c7 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) >> * locks. >> */ >> s->bytes_xfer = 0; >> - s->xfer_limit = 0; >> s->cleanup_bh = 0; >> s->to_dst_file = NULL; >> s->rp_state.from_dst_file = NULL; >> diff --git a/migration/migration.h b/migration/migration.h >> index 99e99e56bd..852eb3c4e9 100644 >> --- a/migration/migration.h >> +++ b/migration/migration.h >> @@ -117,7 +117,6 @@ struct MigrationState >> >> /*< public >*/ >> size_t bytes_xfer; >> - size_t xfer_limit; >> QemuThread thread; >> QEMUBH *cleanup_bh; >> QEMUFile *to_dst_file; >> -- >> 2.19.1 >> >-- >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> Remove this unnecessary field. >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > >Nice; I think that field has been unneeded since 1964a397063967 >just over 5 years ago :-) > Hi, David, I found xfer_limit has an orphan brother, bytes_xfer. Do you want me to send a separate patch or spin v2 to adopt these two together? > >Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > >> --- >> migration/migration.c | 1 - >> migration/migration.h | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index e88acab53b..533c2102c7 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) >> * locks. >> */ >> s->bytes_xfer = 0; >> - s->xfer_limit = 0; >> s->cleanup_bh = 0; >> s->to_dst_file = NULL; >> s->rp_state.from_dst_file = NULL; >> diff --git a/migration/migration.h b/migration/migration.h >> index 99e99e56bd..852eb3c4e9 100644 >> --- a/migration/migration.h >> +++ b/migration/migration.h >> @@ -117,7 +117,6 @@ struct MigrationState >> >> /*< public >*/ >> size_t bytes_xfer; >> - size_t xfer_limit; >> QemuThread thread; >> QEMUBH *cleanup_bh; >> QEMUFile *to_dst_file; >> -- >> 2.19.1 >> >-- >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
* Wei Yang (richardw.yang@linux.intel.com) wrote: > On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: > >* Wei Yang (richardw.yang@linux.intel.com) wrote: > >> MigrationState->xfer_limit is only set to 0 in migrate_init(). > >> > >> Remove this unnecessary field. > >> > >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > > > >Nice; I think that field has been unneeded since 1964a397063967 > >just over 5 years ago :-) > > > > Hi, David, > > I found xfer_limit has an orphan brother, bytes_xfer. > > Do you want me to send a separate patch or spin v2 to adopt these two > together? Either is fine; since we're in 4.0 freeze at the moment, either way it wont get merged for a few weeks. Dave > > > >Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > > >> --- > >> migration/migration.c | 1 - > >> migration/migration.h | 1 - > >> 2 files changed, 2 deletions(-) > >> > >> diff --git a/migration/migration.c b/migration/migration.c > >> index e88acab53b..533c2102c7 100644 > >> --- a/migration/migration.c > >> +++ b/migration/migration.c > >> @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) > >> * locks. > >> */ > >> s->bytes_xfer = 0; > >> - s->xfer_limit = 0; > >> s->cleanup_bh = 0; > >> s->to_dst_file = NULL; > >> s->rp_state.from_dst_file = NULL; > >> diff --git a/migration/migration.h b/migration/migration.h > >> index 99e99e56bd..852eb3c4e9 100644 > >> --- a/migration/migration.h > >> +++ b/migration/migration.h > >> @@ -117,7 +117,6 @@ struct MigrationState > >> > >> /*< public >*/ > >> size_t bytes_xfer; > >> - size_t xfer_limit; > >> QemuThread thread; > >> QEMUBH *cleanup_bh; > >> QEMUFile *to_dst_file; > >> -- > >> 2.19.1 > >> > >-- > >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > -- > Wei Yang > Help you, Help me -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On Mon, Apr 01, 2019 at 09:51:55AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: >> >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> >> >> Remove this unnecessary field. >> >> >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> > >> >Nice; I think that field has been unneeded since 1964a397063967 >> >just over 5 years ago :-) >> > >> >> Hi, David, >> >> I found xfer_limit has an orphan brother, bytes_xfer. >> >> Do you want me to send a separate patch or spin v2 to adopt these two >> together? > >Either is fine; since we're in 4.0 freeze at the moment, either way it >wont get merged for a few weeks. > Got it, thanks :-) >Dave
* Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > * Wei Yang (richardw.yang@linux.intel.com) wrote: > > MigrationState->xfer_limit is only set to 0 in migrate_init(). > > > > Remove this unnecessary field. > > > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > > Nice; I think that field has been unneeded since 1964a397063967 > just over 5 years ago :-) > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Queued > > > --- > > migration/migration.c | 1 - > > migration/migration.h | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/migration/migration.c b/migration/migration.c > > index e88acab53b..533c2102c7 100644 > > --- a/migration/migration.c > > +++ b/migration/migration.c > > @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) > > * locks. > > */ > > s->bytes_xfer = 0; > > - s->xfer_limit = 0; > > s->cleanup_bh = 0; > > s->to_dst_file = NULL; > > s->rp_state.from_dst_file = NULL; > > diff --git a/migration/migration.h b/migration/migration.h > > index 99e99e56bd..852eb3c4e9 100644 > > --- a/migration/migration.h > > +++ b/migration/migration.h > > @@ -117,7 +117,6 @@ struct MigrationState > > > > /*< public >*/ > > size_t bytes_xfer; > > - size_t xfer_limit; > > QemuThread thread; > > QEMUBH *cleanup_bh; > > QEMUFile *to_dst_file; > > -- > > 2.19.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/migration/migration.c b/migration/migration.c index e88acab53b..533c2102c7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) * locks. */ s->bytes_xfer = 0; - s->xfer_limit = 0; s->cleanup_bh = 0; s->to_dst_file = NULL; s->rp_state.from_dst_file = NULL; diff --git a/migration/migration.h b/migration/migration.h index 99e99e56bd..852eb3c4e9 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -117,7 +117,6 @@ struct MigrationState /*< public >*/ size_t bytes_xfer; - size_t xfer_limit; QemuThread thread; QEMUBH *cleanup_bh; QEMUFile *to_dst_file;
MigrationState->xfer_limit is only set to 0 in migrate_init(). Remove this unnecessary field. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> --- migration/migration.c | 1 - migration/migration.h | 1 - 2 files changed, 2 deletions(-)