From patchwork Tue Mar 26 13:20:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10871111 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0F7B01390 for ; Tue, 26 Mar 2019 13:21:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0A9429087 for ; Tue, 26 Mar 2019 13:21:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E47F529018; Tue, 26 Mar 2019 13:21:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 887FB2901F for ; Tue, 26 Mar 2019 13:21:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0C096E075; Tue, 26 Mar 2019 13:20:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0DF36E05B for ; Tue, 26 Mar 2019 13:20:39 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id d1so10704025edd.13 for ; Tue, 26 Mar 2019 06:20:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P1SoUkfA9EPatsMScG2RJ03PBn2MkLtTodK4/2n1CsY=; b=inB/eXY84uhumuLWaSJfCoM8QEszkDNh9HRyAA+X4degQlRktS1wfP66OpivWvI28H DySrDT2tl3Op9LbkcruyFrDjK7NbFck8VdGebWR8mO+MpWp9r+6B9Rp1WDp56FLoJRWa moQ8zhj4bPbpyJ3/5XHAkf86enRAr6zQK47PGJJaHet7cAn8CJ8BhVAqSgjo4vxXiwOd IQDFHmqIFy3ZllsArshH/c6NahIJ8cDjv5A41X9NMmnwU976kIPsSw5M/Fna/pGrkyWI zbHInJf1MgtoJvJQCpf3sgcITu6irvMTdF/sCUIzfIOgVck42ISXAF92StJ/uDkWEFcr FiEQ== X-Gm-Message-State: APjAAAUd7Zfxkvkx2B0RTPY1GjyGim9ke3f02HpdCbJSxno3WK/4NLPd rcgq4cWXaDo0DXRy4ivXVv7+BDyg/tU= X-Google-Smtp-Source: APXvYqwY/ytXicaNbkURPNxr2q0mgtRV/WN7hHZ+/KU4Gu3W8a5FtUWjUrSJ9qXr6Cfxnc7UkcKo+g== X-Received: by 2002:a50:97d0:: with SMTP id f16mr19391774edb.287.1553606437434; Tue, 26 Mar 2019 06:20:37 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id d10sm3668547ejh.66.2019.03.26.06.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 06:20:36 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info Date: Tue, 26 Mar 2019 14:20:05 +0100 Message-Id: <20190326132008.11781-18-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326132008.11781-1-daniel.vetter@ffwll.ch> References: <20190326132008.11781-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P1SoUkfA9EPatsMScG2RJ03PBn2MkLtTodK4/2n1CsY=; b=Cx5AhqVde0nmcqQo3DwuXX9h21ma+VKnO7673eUMWRad+l4t2xnQjpTJ4/fXYmASM/ eEJMDyLy1kYq+TwsNPSoPSECm7TdEXFkeYBaALUxvw/co4WxUlIkGsQaiO81KTXSIBp5 T9zygRyhzAArJjVqO4q8+O0OVU3h+gIBvEx10= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Jonathan Hunter , Thierry Reding , linux-tegra@vger.kernel.org, Daniel Vetter , Thierry Reding Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Another driver that didn't set fbinfo->fix.id before. v2: Fix subject and rebase Acked-by: Thierry Reding Signed-off-by: Daniel Vetter Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-tegra@vger.kernel.org Reviewed-by: Noralf Trønnes Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 0a4ce05e00ab..1dd83a757dba 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,11 +255,9 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->par = helper; info->fbops = &tegra_fb_ops; - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(info, helper, fb->width, fb->height); + drm_fb_helper_fill_info(info, helper, sizes); offset = info->var.xoffset * bytes_per_pixel + info->var.yoffset * fb->pitches[0];