fstests: Don't delete seqres.full file in generic/077
diff mbox series

Message ID 20190326150158.17700-1-nborisov@suse.com
State New
Headers show
Series
  • fstests: Don't delete seqres.full file in generic/077
Related show

Commit Message

Nikolay Borisov March 26, 2019, 3:01 p.m. UTC
When this test finishes there is no 079.full file with output from commands. 
Sometimes this information is useful for post mortem so stop deleting the 
file upon test completion. 

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/generic/077 | 1 -
 1 file changed, 1 deletion(-)

Comments

Darrick J. Wong March 26, 2019, 3:46 p.m. UTC | #1
On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> When this test finishes there is no 079.full file with output from commands. 

"077.full" ?

> Sometimes this information is useful for post mortem so stop deleting the 
> file upon test completion. 
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Looks ok to me otherwise,

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  tests/generic/077 | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/generic/077 b/tests/generic/077
> index 284e25253c9e..d11b49c6ff15 100755
> --- a/tests/generic/077
> +++ b/tests/generic/077
> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
>  _check_scratch_fs
>  
>  echo "*** all done"
> -rm -f $seqres.full

I had wondered about this myself... :)

--D

>  status=0
>  exit
> -- 
> 2.7.4
>
Nikolay Borisov March 28, 2019, 3:40 p.m. UTC | #2
On 26.03.19 г. 17:46 ч., Darrick J. Wong wrote:
> On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
>> When this test finishes there is no 079.full file with output from commands. 
> 
> "077.full" ?

Eryu, would you fold this when merging or shall I resend?

> 
>> Sometimes this information is useful for post mortem so stop deleting the 
>> file upon test completion. 
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> 
> Looks ok to me otherwise,
> 
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
>> ---
>>  tests/generic/077 | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/generic/077 b/tests/generic/077
>> index 284e25253c9e..d11b49c6ff15 100755
>> --- a/tests/generic/077
>> +++ b/tests/generic/077
>> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
>>  _check_scratch_fs
>>  
>>  echo "*** all done"
>> -rm -f $seqres.full
> 
> I had wondered about this myself... :)
> 
> --D
> 
>>  status=0
>>  exit
>> -- 
>> 2.7.4
>>
>
Eryu Guan March 30, 2019, 8:33 a.m. UTC | #3
On Thu, Mar 28, 2019 at 05:40:31PM +0200, Nikolay Borisov wrote:
> 
> 
> On 26.03.19 г. 17:46 ч., Darrick J. Wong wrote:
> > On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> >> When this test finishes there is no 079.full file with output from commands. 
> > 
> > "077.full" ?
> 
> Eryu, would you fold this when merging or shall I resend?

I'll fix it on merge, thanks!

Eryu
> 
> > 
> >> Sometimes this information is useful for post mortem so stop deleting the 
> >> file upon test completion. 
> >>
> >> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> > 
> > Looks ok to me otherwise,
> > 
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> >> ---
> >>  tests/generic/077 | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/tests/generic/077 b/tests/generic/077
> >> index 284e25253c9e..d11b49c6ff15 100755
> >> --- a/tests/generic/077
> >> +++ b/tests/generic/077
> >> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
> >>  _check_scratch_fs
> >>  
> >>  echo "*** all done"
> >> -rm -f $seqres.full
> > 
> > I had wondered about this myself... :)
> > 
> > --D
> > 
> >>  status=0
> >>  exit
> >> -- 
> >> 2.7.4
> >>
> >

Patch
diff mbox series

diff --git a/tests/generic/077 b/tests/generic/077
index 284e25253c9e..d11b49c6ff15 100755
--- a/tests/generic/077
+++ b/tests/generic/077
@@ -73,6 +73,5 @@  cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
 _check_scratch_fs
 
 echo "*** all done"
-rm -f $seqres.full
 status=0
 exit