| Message ID | 20190403072425.42902-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] fbdev: mxsfb: remove set but not used variable 'line_count' | expand |
On 04/03/2019 09:24 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/mxsfb.c: In function 'mxsfb_restore_mode': > drivers/video/fbdev/mxsfb.c:633:11: warning: > variable 'line_count' set but not used [-Wunused-but-set-variable] > > It's never used since introduction in commit f0a523b5e5e2 ("video: Add i.MX23/28 > framebuffer driver") and can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch queued for v5.2 with minor change in the patch summary ("video: fbdev: mxsfb: remove set but not used variable 'line_count'"), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c index a017200a16b3..1fdd1eb38fe0 100644 --- a/drivers/video/fbdev/mxsfb.c +++ b/drivers/video/fbdev/mxsfb.c @@ -630,7 +630,6 @@ static int mxsfb_restore_mode(struct fb_info *fb_info, struct fb_videomode *vmode) { struct mxsfb_info *host = fb_info->par; - unsigned line_count; unsigned period; unsigned long pa, fbsize; int bits_per_pixel, ofs, ret = 0; @@ -717,7 +716,6 @@ static int mxsfb_restore_mode(struct fb_info *fb_info, writel(fb_info->fix.smem_start, host->base + host->devdata->next_buf); } - line_count = fb_info->fix.smem_len / fb_info->fix.line_length; fb_info->fix.ypanstep = 1; clk_prepare_enable(host->clk);
Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/mxsfb.c: In function 'mxsfb_restore_mode': drivers/video/fbdev/mxsfb.c:633:11: warning: variable 'line_count' set but not used [-Wunused-but-set-variable] It's never used since introduction in commit f0a523b5e5e2 ("video: Add i.MX23/28 framebuffer driver") and can be removed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/video/fbdev/mxsfb.c | 2 -- 1 file changed, 2 deletions(-)