From patchwork Thu Apr 4 11:57:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Dooks X-Patchwork-Id: 10885497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 441BC1669 for ; Thu, 4 Apr 2019 11:57:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F06228A3E for ; Thu, 4 Apr 2019 11:57:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23C4028A46; Thu, 4 Apr 2019 11:57:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7BB828A3E for ; Thu, 4 Apr 2019 11:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728885AbfDDL5k (ORCPT ); Thu, 4 Apr 2019 07:57:40 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:48177 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbfDDL5k (ORCPT ); Thu, 4 Apr 2019 07:57:40 -0400 Received: from [167.98.27.226] (helo=rainbowdash.codethink.co.uk) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1hC0zy-0008DC-3x; Thu, 04 Apr 2019 12:57:38 +0100 Received: from ben by rainbowdash.codethink.co.uk with local (Exim 4.92) (envelope-from ) id 1hC0zw-0000ee-Fs; Thu, 04 Apr 2019 12:57:36 +0100 From: Ben Dooks To: linux-sparse@vger.kernel.org Cc: Ben Dooks Subject: [PATCH 4/5] add -Wformat Date: Thu, 4 Apr 2019 12:57:33 +0100 Message-Id: <20190404115734.2403-5-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190404115734.2403-1-ben.dooks@codethink.co.uk> References: <20190404115734.2403-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add option to enable/disable format checking (and default it to off) Signed-off-by: Ben Dooks --- Changes since v1: - Default -Wformat off Changes since v2: - Spelling fixes fixup format docs --- evaluate.c | 4 ++-- lib.c | 2 ++ lib.h | 1 + sparse.1 | 9 +++++++++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/evaluate.c b/evaluate.c index 001b8e0..539b0c7 100644 --- a/evaluate.c +++ b/evaluate.c @@ -2761,7 +2761,7 @@ static int evaluate_arguments(struct symbol *fn, struct expression_list *head) /* do this first, otherwise the arugment info may get lost or changed * later on in the evaluation loop by degenerate() */ - if (fn->ctype.printf_va_start) + if (Wformat && fn->ctype.printf_va_start) fmt_string = get_printf_fmt(fn, head); PREPARE_PTR_LIST(argument_types, argtype); @@ -2801,7 +2801,7 @@ static int evaluate_arguments(struct symbol *fn, struct expression_list *head) } END_FOR_EACH_PTR(expr); FINISH_PTR_LIST(argtype); - if (fn->ctype.printf_va_start) + if (Wformat && fn->ctype.printf_va_start) evaluate_format_printf(fmt_string, fn, head); return 1; diff --git a/lib.c b/lib.c index 83e6a1e..b3bb2e6 100644 --- a/lib.c +++ b/lib.c @@ -269,6 +269,7 @@ int Wimplicit_int = 1; int Winit_cstring = 0; int Wint_to_pointer_cast = 1; int Wenum_mismatch = 1; +int Wformat = 0; int Wsparse_error = 0; int Wmemcpy_max_count = 1; int Wnon_pointer_null = 1; @@ -651,6 +652,7 @@ static const struct flag warnings[] = { { "implicit-int", &Wimplicit_int }, { "init-cstring", &Winit_cstring }, { "int-to-pointer-cast", &Wint_to_pointer_cast }, + { "format", &Wformat }, { "memcpy-max-count", &Wmemcpy_max_count }, { "non-pointer-null", &Wnon_pointer_null }, { "old-initializer", &Wold_initializer }, diff --git a/lib.h b/lib.h index 322408b..c606807 100644 --- a/lib.h +++ b/lib.h @@ -152,6 +152,7 @@ extern int Wdefault_bitfield_sign; extern int Wdesignated_init; extern int Wdo_while; extern int Wenum_mismatch; +extern int Wformat; extern int Wsparse_error; extern int Wimplicit_int; extern int Winit_cstring; diff --git a/sparse.1 b/sparse.1 index 78d0b1e..af9a428 100644 --- a/sparse.1 +++ b/sparse.1 @@ -260,6 +260,15 @@ trouble. Sparse does not issue these warnings by default. . .TP +.B \-Wformat +Warn about parameter mismatch to any variadic function which specifies +where the format string is specified with the +.BI __attribute__((format( type, message, va_start ))) +attribute. + +Sparse does not issue these warnings by default. To turn them on, use +\fB\-Wno\-format\fR +.TP .B \-Wmemcpy\-max\-count Warn about call of \fBmemcpy()\fR, \fBmemset()\fR, \fBcopy_from_user()\fR, or \fBcopy_to_user()\fR with a large compile-time byte count.