scrub: fix typo in unicrash header file
diff mbox series

Message ID 9e34ab3e-b9ed-6c4c-ce69-97f0f78b9503@redhat.com
State Accepted
Headers show
Series
  • scrub: fix typo in unicrash header file
Related show

Commit Message

Eric Sandeen April 4, 2019, 5:24 p.m. UTC
The no-op #definintion was missing 'fs_' so remained undefined
in the #else case.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Darrick J. Wong April 4, 2019, 6:01 p.m. UTC | #1
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote:
> The no-op #definintion was missing 'fs_' so remained undefined
> in the #else case.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

LGTM,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/scrub/unicrash.h b/scrub/unicrash.h
> index 85fcabc..fb8f5f7 100644
> --- a/scrub/unicrash.h
> +++ b/scrub/unicrash.h
> @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
>  #else
>  # define unicrash_dir_init(u, c, b)		(true)
>  # define unicrash_xattr_init(u, c, b)		(true)
> -# define unicrash_label_init(u, c)		(true)
> +# define unicrash_fs_label_init(u, c)		(true)
>  # define unicrash_free(u)			do {(u) = (u);} while (0)
>  # define unicrash_check_dir_name(u, d, n)	(true)
>  # define unicrash_check_xattr_name(u, d, n)	(true)
>
Bill O'Donnell April 4, 2019, 6:06 p.m. UTC | #2
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote:
> The no-op #definintion was missing 'fs_' so remained undefined
> in the #else case.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

Looks good.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> 
> diff --git a/scrub/unicrash.h b/scrub/unicrash.h
> index 85fcabc..fb8f5f7 100644
> --- a/scrub/unicrash.h
> +++ b/scrub/unicrash.h
> @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
>  #else
>  # define unicrash_dir_init(u, c, b)		(true)
>  # define unicrash_xattr_init(u, c, b)		(true)
> -# define unicrash_label_init(u, c)		(true)
> +# define unicrash_fs_label_init(u, c)		(true)
>  # define unicrash_free(u)			do {(u) = (u);} while (0)
>  # define unicrash_check_dir_name(u, d, n)	(true)
>  # define unicrash_check_xattr_name(u, d, n)	(true)
>

Patch
diff mbox series

diff --git a/scrub/unicrash.h b/scrub/unicrash.h
index 85fcabc..fb8f5f7 100644
--- a/scrub/unicrash.h
+++ b/scrub/unicrash.h
@@ -28,7 +28,7 @@  bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
 #else
 # define unicrash_dir_init(u, c, b)		(true)
 # define unicrash_xattr_init(u, c, b)		(true)
-# define unicrash_label_init(u, c)		(true)
+# define unicrash_fs_label_init(u, c)		(true)
 # define unicrash_free(u)			do {(u) = (u);} while (0)
 # define unicrash_check_dir_name(u, d, n)	(true)
 # define unicrash_check_xattr_name(u, d, n)	(true)