| Message ID | 9e34ab3e-b9ed-6c4c-ce69-97f0f78b9503@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scrub: fix typo in unicrash header file | expand |
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote: > The no-op #definintion was missing 'fs_' so remained undefined > in the #else case. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> LGTM, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > > diff --git a/scrub/unicrash.h b/scrub/unicrash.h > index 85fcabc..fb8f5f7 100644 > --- a/scrub/unicrash.h > +++ b/scrub/unicrash.h > @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr, > #else > # define unicrash_dir_init(u, c, b) (true) > # define unicrash_xattr_init(u, c, b) (true) > -# define unicrash_label_init(u, c) (true) > +# define unicrash_fs_label_init(u, c) (true) > # define unicrash_free(u) do {(u) = (u);} while (0) > # define unicrash_check_dir_name(u, d, n) (true) > # define unicrash_check_xattr_name(u, d, n) (true) >
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote: > The no-op #definintion was missing 'fs_' so remained undefined > in the #else case. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > --- Looks good. Reviewed-by: Bill O'Donnell <billodo@redhat.com> > > diff --git a/scrub/unicrash.h b/scrub/unicrash.h > index 85fcabc..fb8f5f7 100644 > --- a/scrub/unicrash.h > +++ b/scrub/unicrash.h > @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr, > #else > # define unicrash_dir_init(u, c, b) (true) > # define unicrash_xattr_init(u, c, b) (true) > -# define unicrash_label_init(u, c) (true) > +# define unicrash_fs_label_init(u, c) (true) > # define unicrash_free(u) do {(u) = (u);} while (0) > # define unicrash_check_dir_name(u, d, n) (true) > # define unicrash_check_xattr_name(u, d, n) (true) >
diff --git a/scrub/unicrash.h b/scrub/unicrash.h index 85fcabc..fb8f5f7 100644 --- a/scrub/unicrash.h +++ b/scrub/unicrash.h @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr, #else # define unicrash_dir_init(u, c, b) (true) # define unicrash_xattr_init(u, c, b) (true) -# define unicrash_label_init(u, c) (true) +# define unicrash_fs_label_init(u, c) (true) # define unicrash_free(u) do {(u) = (u);} while (0) # define unicrash_check_dir_name(u, d, n) (true) # define unicrash_check_xattr_name(u, d, n) (true)
The no-op #definintion was missing 'fs_' so remained undefined in the #else case. Signed-off-by: Eric Sandeen <sandeen@redhat.com> ---