From patchwork Fri Apr 5 16:33:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 10887633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C4A1B17E1 for ; Fri, 5 Apr 2019 16:35:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA6B828785 for ; Fri, 5 Apr 2019 16:35:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C4F728B1C; Fri, 5 Apr 2019 16:35:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2CE0B28785 for ; Fri, 5 Apr 2019 16:35:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hCRmI-0002MT-7X; Fri, 05 Apr 2019 16:33:18 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hCRmG-0002MO-0D for xen-devel@lists.xen.org; Fri, 05 Apr 2019 16:33:16 +0000 X-Inumbo-ID: 8207088f-57c0-11e9-92d7-bc764e045a96 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 8207088f-57c0-11e9-92d7-bc764e045a96; Fri, 05 Apr 2019 16:33:14 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,313,1549929600"; d="scan'208";a="82873404" From: Andrew Cooper To: Xen-devel Date: Fri, 5 Apr 2019 17:33:10 +0100 Message-ID: <1554481990-7569-1-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] common/gnttab: Process softirqs while dumping grant tables X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , Ian Jackson , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP OSSTests upgrade to Jessie has identified that with a sufficiently large grant table, a watchdog timeout can occur. http://logs.test-lab.xenproject.org/osstest/logs/134399/test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow/serial-chardonnay0.log Reported-by: Ian Jackson Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Stefano Stabellini CC: Julien Grall CC: Ian Jackson --- xen/common/grant_table.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 80728ea..344b3ee 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -3956,6 +3956,9 @@ static void gnttab_usage_print(struct domain *rd) uint16_t status; uint64_t frame; + if ( !(ref & 31) ) + process_pending_softirqs(); + act = active_entry_acquire(gt, ref); if ( !act->pin ) {