From patchwork Fri Apr 5 17:58:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 10887685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AEFBC1575 for ; Fri, 5 Apr 2019 18:00:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9709728925 for ; Fri, 5 Apr 2019 18:00:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 876852893B; Fri, 5 Apr 2019 18:00:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 24A9328925 for ; Fri, 5 Apr 2019 18:00:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hCT6e-0000f1-NA; Fri, 05 Apr 2019 17:58:24 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hCT6c-0000eY-GT for xen-devel@lists.xenproject.org; Fri, 05 Apr 2019 17:58:22 +0000 X-Inumbo-ID: 6604721d-57cc-11e9-92d7-bc764e045a96 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 6604721d-57cc-11e9-92d7-bc764e045a96; Fri, 05 Apr 2019 17:58:20 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,313,1549929600"; d="scan'208";a="82881060" From: Anthony PERARD To: Date: Fri, 5 Apr 2019 18:58:10 +0100 Message-ID: <20190405175811.7446-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190405175811.7446-1-anthony.perard@citrix.com> References: <20190405175811.7446-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/3] libxl: Constify src of device_compare_fn_t X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP All functions libxl_device_*_copy which implements device_compare_fn_t already have the `src' parameter defined with const. Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- tools/libxl/libxl_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index c75c98156a..34dc886505 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -3726,7 +3726,7 @@ typedef int (*device_set_default_fn_t)(libxl__gc *, uint32_t, void *, bool); typedef int (*device_to_device_fn_t)(libxl__gc *, uint32_t, void *, libxl__device *); typedef void (*device_init_fn_t)(void *); -typedef void (*device_copy_fn_t)(libxl_ctx *, void *, void *); +typedef void (*device_copy_fn_t)(libxl_ctx *, void *dst, const void *src); typedef void (*device_dispose_fn_t)(void *); typedef int (*device_compare_fn_t)(const void *, const void *); typedef void (*device_merge_fn_t)(libxl_ctx *, void *, void *);