@@ -65,15 +65,20 @@ int meson_aoclkc_probe(struct platform_device *pdev)
return ret;
}
- /*
- * Populate regmap and register all clks
- */
- for (clkid = 0; clkid < data->num_clks; clkid++) {
+ /* Populate regmap */
+ for (clkid = 0; clkid < data->num_clks; clkid++)
data->clks[clkid]->map = regmap;
+ /* Register all clks */
+ for (clkid = 0; clkid < data->hw_data->num; clkid++) {
+ if (!data->hw_data->hws[clkid])
+ continue;
+
ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]);
- if (ret)
+ if (ret) {
+ dev_err(dev, "Clock registration failed\n");
return ret;
+ }
}
return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * stable/linux-4.19.y boot bisection: v4.19.34 on meson-gxl-s905x-libretech-cc Summary: Start: 4d552acf3370 Linux 4.19.34 Details: https://kernelci.org/boot/id/5ca7d18659b51406b8fe6019 Plain log: https://storage.kernelci.org//stable/linux-4.19.y/v4.19.34/arm64/defconfig/gcc-7/lab-baylibre/boot-meson-gxl-s905x-libretech-cc.txt HTML log: https://storage.kernelci.org//stable/linux-4.19.y/v4.19.34/arm64/defconfig/gcc-7/lab-baylibre/boot-meson-gxl-s905x-libretech-cc.html Result: c8e4f8406842 clk: meson: clean-up clock registration Checks: revert: PASS verify: PASS Parameters: Tree: stable URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Branch: linux-4.19.y Target: meson-gxl-s905x-libretech-cc CPU arch: arm64 Lab: lab-baylibre Compiler: gcc-7 Config: defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit c8e4f8406842332fb55cd792016e5dac266f6354 Author: Jerome Brunet <jbrunet@baylibre.com> Date: Fri Dec 21 17:02:36 2018 +0100 clk: meson: clean-up clock registration [ Upstream commit 8d9981efbcab066d17af4d3c85c169200f6f78df ] Order, ids and size between the table of regmap clocks and the onecell data table could be different. Set regmap pointer in all the regmap clocks before starting the registration using the onecell data, to make sure we don't get into an incoherent situation. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Link: https://lkml.kernel.org/r/20181221160239.26265-3-jbrunet@baylibre.com Signed-off-by: Sasha Levin <sashal@kernel.org> ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [4b3a3ab00fa7a951eb1d7568c71855e75fd5af85] Linux 4.19.33 git bisect good 4b3a3ab00fa7a951eb1d7568c71855e75fd5af85 # bad: [4d552acf337038028f7e2f63a927afb7adf65fc1] Linux 4.19.34 git bisect bad 4d552acf337038028f7e2f63a927afb7adf65fc1 # good: [b13eb5245f9f730e79ab17593c4e3c8a62fee3b4] HID: intel-ish-hid: avoid binding wrong ishtp_cl_device git bisect good b13eb5245f9f730e79ab17593c4e3c8a62fee3b4 # good: [30d503bae9673ff6b0c67c6fa61b95db66319088] ARM: avoid Cortex-A9 livelock on tight dmb loops git bisect good 30d503bae9673ff6b0c67c6fa61b95db66319088 # good: [c55f4a6e798dad7383f4e4f99d351d6016e943a2] dmaengine: qcom_hidma: assign channel cookie correctly git bisect good c55f4a6e798dad7383f4e4f99d351d6016e943a2 # good: [52cd9e0e43c7bda1621a2ce66765a4a369967caf] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure git bisect good 52cd9e0e43c7bda1621a2ce66765a4a369967caf # bad: [986a2bb54a31179b0c99b94743723d49388ad900] Input: soc_button_array - fix mapping of the 5th GPIO in a PNP0C40 device git bisect bad 986a2bb54a31179b0c99b94743723d49388ad900 # bad: [c8e4f8406842332fb55cd792016e5dac266f6354] clk: meson: clean-up clock registration git bisect bad c8e4f8406842332fb55cd792016e5dac266f6354 # good: [6251c1db04f2ac1ef799763da0f2fa1821dde403] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup git bisect good 6251c1db04f2ac1ef799763da0f2fa1821dde403 # first bad commit: [c8e4f8406842332fb55cd792016e5dac266f6354] clk: meson: clean-up clock registration -------------------------------------------------------------------------------