From patchwork Sat Apr 6 03:42:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 10888069 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F036315AC for ; Sat, 6 Apr 2019 03:43:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAB0928B6B for ; Sat, 6 Apr 2019 03:43:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9DB8E28B7D; Sat, 6 Apr 2019 03:43:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 214D328B6B for ; Sat, 6 Apr 2019 03:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7c1by4iRpl99DCmUZr17OkviqEARYYGCl3vkWtB4rPg=; b=u5MquDuMnUD5dn 8SYPMYK4S/PEKVrGiEf689QP638y/vRQYnUkAY9SNM8ERhgaDaMaj46EG1wyxhCvV+75464fd2yEL fog6qUmTt5tFP2trF65pjPuY/H1NrwjzclYx8hc7F6nTXSTCa4N2a9jAoOnpeeylA9ex08kkurNRr XSsUCckBi3568NaisVFmJaJDieLLXWxJtxQSmpg9ZgUOMGeRCV0kA2qMIj0uH+B9yryGaW1qmm1Su 3kHcD/5SBDoxEujBCUhP7WKdeyuEKkpFjmJXRqU15sUM0nId7fNbImEeiLEJOTpDfwGUMyDpkbnhf fSCASUFpbArFt4k/PqIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCcET-0005u7-R1; Sat, 06 Apr 2019 03:43:05 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCcEN-0005rY-IJ for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2019 03:43:03 +0000 Received: by mail-wr1-x443.google.com with SMTP id j9so10101044wrn.6 for ; Fri, 05 Apr 2019 20:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=ys2IsLJ1PvhlZKBx420jkP3TGrV2rTELbRBFIog6p54=; b=TEgfoxzZ1+NJEbPF601bOhR3XSbnA3qNoEG42OAMIWcLeApd7FJlNusbnw/S+nVb/y WK8d4zmAZRo3onYt6+SpMPADqv0Umn/hu/IV+n+6s1Bvql+EWwXwRP/gEB3Gsvk7fARP KRVrk2kf49queWBuPdMnrbpBz5eCAhxTqSFkOCyFyNmdhwPcsZn3droWGpvP31REfON+ szkQVi43ltaU8SGUHwoZWkiWzvjm2qhi44R7Vdz84GDuiYNZQHU7V+bpCVy88tqfVx+J Jcxp2zsIWAKYPDFJAj8RR9pTuyjaZfJKCwn/HVBfiakj5cNFUKTsu9KeDAgnmTwcD7Aj 6cHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=ys2IsLJ1PvhlZKBx420jkP3TGrV2rTELbRBFIog6p54=; b=ZBMO8XL7G+BAMpmganXYtbqmw+IT/no8YcideEFSJi7bp68KHJAAEpPoBvpCOlB1Pz OAKcZxTJ+bQgKxqmN+Ep2XpNPZy/MzHVMyVlgpGOfT6YWR8kFjiVeX0auS8LDpxAsg5O 4Fu7yq81lxzIO9N0h54pDgEPhcoXs6OwB4J6Ygrn7TtlXO/6EZRy0n1XR7s6oMVFZ+B0 YHczBp4EnBPJeGxMOlS4JGg1pRtb6szYAqGehkUYOMZuiZL26c6XxUz34dyhVGopNeyI VKPKInQUJp07KYthpN4VFRiRZUDF4Lhh8/XfgAzKvbhNgrMggMZO3CM5Isu0r3G7/BNl oByw== X-Gm-Message-State: APjAAAU9ztn7/dcA/GokcTOolS/iiOPzrtgEGbaCj2MgvJldyGGGwwEt d1bMEi08vm1xsNw/MS2Z+dsvAQ== X-Google-Smtp-Source: APXvYqwMEFIY7Sy/YXMXfRtb1EKad76xq1Qu/T9Dd0BklGz1SMP+t7KlNc4KS9/FefQzbIxJCXGgxQ== X-Received: by 2002:a5d:6682:: with SMTP id l2mr11066388wru.33.1554522176822; Fri, 05 Apr 2019 20:42:56 -0700 (PDT) Received: from [148.251.42.114] ([2a01:4f8:201:9271::2]) by smtp.gmail.com with ESMTPSA id z74sm11703671wmc.2.2019.04.05.20.42.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 20:42:56 -0700 (PDT) Message-ID: <5ca82040.1c69fb81.ab86d.b4f9@mx.google.com> Date: Fri, 05 Apr 2019 20:42:56 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Kernel: v4.19.34 X-Kernelci-Report-Type: bisect X-Kernelci-Tree: stable X-Kernelci-Lab-Name: lab-baylibre X-Kernelci-Branch: linux-4.19.y Subject: stable/linux-4.19.y boot bisection: v4.19.34 on meson-gxl-s905x-libretech-cc To: tomeu.vizoso@collabora.com, Sasha Levin , guillaume.tucker@collabora.com, mgalka@collabora.com, Neil Armstrong , broonie@kernel.org, matthew.hart@linaro.org, khilman@baylibre.com, enric.balletbo@collabora.com, Jerome Brunet From: "kernelci.org bot" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_204259_831832_A0C11739 X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Kevin Hilman , Michael Turquette , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * stable/linux-4.19.y boot bisection: v4.19.34 on meson-gxl-s905x-libretech-cc Summary: Start: 4d552acf3370 Linux 4.19.34 Details: https://kernelci.org/boot/id/5ca7d18659b51406b8fe6019 Plain log: https://storage.kernelci.org//stable/linux-4.19.y/v4.19.34/arm64/defconfig/gcc-7/lab-baylibre/boot-meson-gxl-s905x-libretech-cc.txt HTML log: https://storage.kernelci.org//stable/linux-4.19.y/v4.19.34/arm64/defconfig/gcc-7/lab-baylibre/boot-meson-gxl-s905x-libretech-cc.html Result: c8e4f8406842 clk: meson: clean-up clock registration Checks: revert: PASS verify: PASS Parameters: Tree: stable URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Branch: linux-4.19.y Target: meson-gxl-s905x-libretech-cc CPU arch: arm64 Lab: lab-baylibre Compiler: gcc-7 Config: defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit c8e4f8406842332fb55cd792016e5dac266f6354 Author: Jerome Brunet Date: Fri Dec 21 17:02:36 2018 +0100 clk: meson: clean-up clock registration [ Upstream commit 8d9981efbcab066d17af4d3c85c169200f6f78df ] Order, ids and size between the table of regmap clocks and the onecell data table could be different. Set regmap pointer in all the regmap clocks before starting the registration using the onecell data, to make sure we don't get into an incoherent situation. Signed-off-by: Jerome Brunet Acked-by: Neil Armstrong Signed-off-by: Neil Armstrong Link: https://lkml.kernel.org/r/20181221160239.26265-3-jbrunet@baylibre.com Signed-off-by: Sasha Levin ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [4b3a3ab00fa7a951eb1d7568c71855e75fd5af85] Linux 4.19.33 git bisect good 4b3a3ab00fa7a951eb1d7568c71855e75fd5af85 # bad: [4d552acf337038028f7e2f63a927afb7adf65fc1] Linux 4.19.34 git bisect bad 4d552acf337038028f7e2f63a927afb7adf65fc1 # good: [b13eb5245f9f730e79ab17593c4e3c8a62fee3b4] HID: intel-ish-hid: avoid binding wrong ishtp_cl_device git bisect good b13eb5245f9f730e79ab17593c4e3c8a62fee3b4 # good: [30d503bae9673ff6b0c67c6fa61b95db66319088] ARM: avoid Cortex-A9 livelock on tight dmb loops git bisect good 30d503bae9673ff6b0c67c6fa61b95db66319088 # good: [c55f4a6e798dad7383f4e4f99d351d6016e943a2] dmaengine: qcom_hidma: assign channel cookie correctly git bisect good c55f4a6e798dad7383f4e4f99d351d6016e943a2 # good: [52cd9e0e43c7bda1621a2ce66765a4a369967caf] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure git bisect good 52cd9e0e43c7bda1621a2ce66765a4a369967caf # bad: [986a2bb54a31179b0c99b94743723d49388ad900] Input: soc_button_array - fix mapping of the 5th GPIO in a PNP0C40 device git bisect bad 986a2bb54a31179b0c99b94743723d49388ad900 # bad: [c8e4f8406842332fb55cd792016e5dac266f6354] clk: meson: clean-up clock registration git bisect bad c8e4f8406842332fb55cd792016e5dac266f6354 # good: [6251c1db04f2ac1ef799763da0f2fa1821dde403] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup git bisect good 6251c1db04f2ac1ef799763da0f2fa1821dde403 # first bad commit: [c8e4f8406842332fb55cd792016e5dac266f6354] clk: meson: clean-up clock registration ------------------------------------------------------------------------------- diff --git a/drivers/clk/meson/meson-aoclk.c b/drivers/clk/meson/meson-aoclk.c index f965845917e3..258c8d259ea1 100644 --- a/drivers/clk/meson/meson-aoclk.c +++ b/drivers/clk/meson/meson-aoclk.c @@ -65,15 +65,20 @@ int meson_aoclkc_probe(struct platform_device *pdev) return ret; } - /* - * Populate regmap and register all clks - */ - for (clkid = 0; clkid < data->num_clks; clkid++) { + /* Populate regmap */ + for (clkid = 0; clkid < data->num_clks; clkid++) data->clks[clkid]->map = regmap; + /* Register all clks */ + for (clkid = 0; clkid < data->hw_data->num; clkid++) { + if (!data->hw_data->hws[clkid]) + continue; + ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]); - if (ret) + if (ret) { + dev_err(dev, "Clock registration failed\n"); return ret; + } } return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,