From patchwork Sat Apr 6 06:24:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 10888081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7AFBB13B5 for ; Sat, 6 Apr 2019 06:24:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D5601FFE6 for ; Sat, 6 Apr 2019 06:24:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B6CB28B7E; Sat, 6 Apr 2019 06:24:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9D25128B75 for ; Sat, 6 Apr 2019 06:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WWtOZ1u+T//X0pLlG/fNS19GI0XzlY0PZpp6/ywFDjQ=; b=QQpPJLxQspN0PJ EZHOrWADtyHrjiGvfGJxu9Ahrl+3Qu//obfPZnj0sIMxgn7aFoLOMP+GZTP1YmRvAYmpcvDGIYVr+ 8U9pGTFPRFtE1iQxxUm/vKe0F9bKSrX/SX0rIxxPgysZIRo5OIYc5E4ssTXvSPMiqIBUX1aR+7+Fv 4EJ+yscAeY8PohKsxrrZz9adKIBuVzI93skI9gVIdmTUuCV1ghkcWg6VuepDrZJI74mp2g3JyJRKA 1zsWvmsl7BWxTbXUOai2jn7lzaSzz80Ohj3o6IPLc7uRp6+IKZXAedlRKIS1re5aUkCgFLnorQFt+ 2z62wRdX2H7StRvor13w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCeke-0007kU-70; Sat, 06 Apr 2019 06:24:28 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCekZ-0007ih-4h for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2019 06:24:26 +0000 Received: by mail-wm1-x342.google.com with SMTP id w15so9231907wmc.3 for ; Fri, 05 Apr 2019 23:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=Z2ZMBmLf5H7LCVZIEoHGY0nbwwyjgL/lWhAJjSfUtaM=; b=zK3sf5eyo3xRdsPPJ/62NdCo0f4jC9MIU08rhhdZpegZD/CX2Wzml01F097nqVW2D+ zrNcvZdeLu2Tibf0wPge3bhfPo+orOIn1njT5M8XvAyc1jH1pWNPxoZUhxMAhuWHS4CZ Y4AHwKehQQwYNSZ2ru3PPBz+KVAm6aaY05aUl1oi8WsyORyf+FYoc/3vYD7pi7jTrg1g 46r6YTyDFRSB31ZvS0UsaqoBsfDuQcmPIeioaYhBRt9njfcZQF/3CVX74hkA47GJHudV YwCqYfaNwJsqdRExlC0AwTrei6T3W8f3IRGC/ZBGIcOiXrfmK0LyP1dLCMKyYYM7jum1 N9fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=Z2ZMBmLf5H7LCVZIEoHGY0nbwwyjgL/lWhAJjSfUtaM=; b=en9eBiY1Da9CSmz6jzcv9CTSPB5m0rvLGjtWBSTTu8M25qcEWUI3WXLL0tYNaQosd9 xkmayTkJFXIN+JR34hlXAV5OYzE2bsLit1Io0MOxQsBsHYBiMkk6NRWz0oN3vSj6qa5Q 3+bviKtfor1XtuDsj839ozWjrdzA2rL21dL/ojlCSjuIfewKrD9gBF74PdgXA3z5JdPX 4ezQN1eL4Iwks3QPHJfeNcpc8j45posc7Y5+LaUSm4DWJ8AOxhf+rL8rc9xkE/m/s6PQ M7ix9ES90+sq+Upgs/7b0OlpDp8gQPOCxZ9B/J/GyVwV7Ol31yj9is4cE/cXQ73NHXGA Ca2w== X-Gm-Message-State: APjAAAXDZIvqtq9D4K6X67NLWbxKfJShQpyrfdHpayxXpo00bCgkfy5k sg3Dj3XFaBk7IxiUfYRqJ9M6uA== X-Google-Smtp-Source: APXvYqx84WcrdCZw7xcJcBhhnwS+nDR++bNRGswqBKQnYvX38PPMzk3gKvt0OMDCmhAIDhWY/Eh6rQ== X-Received: by 2002:a1c:9ad6:: with SMTP id c205mr10692405wme.46.1554531861469; Fri, 05 Apr 2019 23:24:21 -0700 (PDT) Received: from [148.251.42.114] ([2a01:4f8:201:9271::2]) by smtp.gmail.com with ESMTPSA id z140sm7394764wmc.27.2019.04.05.23.24.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 23:24:20 -0700 (PDT) Message-ID: <5ca84614.1c69fb81.e2ab3.2e61@mx.google.com> Date: Fri, 05 Apr 2019 23:24:20 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Kernel: v5.0.7 X-Kernelci-Report-Type: bisect X-Kernelci-Tree: stable X-Kernelci-Lab-Name: lab-baylibre X-Kernelci-Branch: linux-5.0.y Subject: stable/linux-5.0.y boot bisection: v5.0.7 on meson-gxl-s805x-p241 To: tomeu.vizoso@collabora.com, Sasha Levin , guillaume.tucker@collabora.com, mgalka@collabora.com, Neil Armstrong , broonie@kernel.org, matthew.hart@linaro.org, khilman@baylibre.com, enric.balletbo@collabora.com, Jerome Brunet From: "kernelci.org bot" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_232423_241995_646DC997 X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Kevin Hilman , Michael Turquette , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * stable/linux-5.0.y boot bisection: v5.0.7 on meson-gxl-s805x-p241 Summary: Start: 8b298d3a0bd5 Linux 5.0.7 Details: https://kernelci.org/boot/id/5ca7df3959b5141abafe6036 Plain log: https://storage.kernelci.org//stable/linux-5.0.y/v5.0.7/arm64/defconfig/gcc-7/lab-baylibre/boot-meson-gxl-s805x-p241.txt HTML log: https://storage.kernelci.org//stable/linux-5.0.y/v5.0.7/arm64/defconfig/gcc-7/lab-baylibre/boot-meson-gxl-s805x-p241.html Result: 9b0f430450cf clk: meson: clean-up clock registration Checks: revert: PASS verify: PASS Parameters: Tree: stable URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Branch: linux-5.0.y Target: meson-gxl-s805x-p241 CPU arch: arm64 Lab: lab-baylibre Compiler: gcc-7 Config: defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 9b0f430450cf230e736bc40f95bf34fbdb99cead Author: Jerome Brunet Date: Fri Dec 21 17:02:36 2018 +0100 clk: meson: clean-up clock registration [ Upstream commit 8d9981efbcab066d17af4d3c85c169200f6f78df ] Order, ids and size between the table of regmap clocks and the onecell data table could be different. Set regmap pointer in all the regmap clocks before starting the registration using the onecell data, to make sure we don't get into an incoherent situation. Signed-off-by: Jerome Brunet Acked-by: Neil Armstrong Signed-off-by: Neil Armstrong Link: https://lkml.kernel.org/r/20181221160239.26265-3-jbrunet@baylibre.com Signed-off-by: Sasha Levin ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [820c1fa515010d280551075da59fc2668ba8b3ae] Linux 5.0.6 git bisect good 820c1fa515010d280551075da59fc2668ba8b3ae # bad: [8b298d3a0bd5feeb47129c4889356b38b78ab231] Linux 5.0.7 git bisect bad 8b298d3a0bd5feeb47129c4889356b38b78ab231 # good: [55d7152d37dccfa9add45df82fd45c373e032f46] cgroup, rstat: Don't flush subtree root unless necessary git bisect good 55d7152d37dccfa9add45df82fd45c373e032f46 # good: [8b3b22aa7c558e713a179710a6f1e2fdbef44b20] block, bfq: fix queue removal from weights tree git bisect good 8b3b22aa7c558e713a179710a6f1e2fdbef44b20 # good: [ebd0f3066c35bd27d3a4b224135e638eeaf70b8d] netfilter: physdev: relax br_netfilter dependency git bisect good ebd0f3066c35bd27d3a4b224135e638eeaf70b8d # bad: [9b0f430450cf230e736bc40f95bf34fbdb99cead] clk: meson: clean-up clock registration git bisect bad 9b0f430450cf230e736bc40f95bf34fbdb99cead # good: [bfb59eabe2c940c6869f128200f2047d46215845] drm: Auto-set allow_fb_modifiers when given modifiers at plane init git bisect good bfb59eabe2c940c6869f128200f2047d46215845 # good: [ab79dc3ef0244c9b3d712d0cef17b74c363d6069] brcmfmac: Use firmware_request_nowarn for the clm_blob git bisect good ab79dc3ef0244c9b3d712d0cef17b74c363d6069 # good: [c8a8dd1d85ca715ec65169feac54a7a06b8d2a29] x86/build: Mark per-CPU symbols as absolute explicitly for LLD git bisect good c8a8dd1d85ca715ec65169feac54a7a06b8d2a29 # good: [a644d2d28baf8472368903b28823cf85c9a13a1d] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup git bisect good a644d2d28baf8472368903b28823cf85c9a13a1d # first bad commit: [9b0f430450cf230e736bc40f95bf34fbdb99cead] clk: meson: clean-up clock registration ------------------------------------------------------------------------------- diff --git a/drivers/clk/meson/meson-aoclk.c b/drivers/clk/meson/meson-aoclk.c index f965845917e3..258c8d259ea1 100644 --- a/drivers/clk/meson/meson-aoclk.c +++ b/drivers/clk/meson/meson-aoclk.c @@ -65,15 +65,20 @@ int meson_aoclkc_probe(struct platform_device *pdev) return ret; } - /* - * Populate regmap and register all clks - */ - for (clkid = 0; clkid < data->num_clks; clkid++) { + /* Populate regmap */ + for (clkid = 0; clkid < data->num_clks; clkid++) data->clks[clkid]->map = regmap; + /* Register all clks */ + for (clkid = 0; clkid < data->hw_data->num; clkid++) { + if (!data->hw_data->hws[clkid]) + continue; + ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]); - if (ret) + if (ret) { + dev_err(dev, "Clock registration failed\n"); return ret; + } } return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,