diff mbox series

[2/3] devantech-srf04.yaml: add Maxbotix ultrasonic iio proximity sensors

Message ID 20190409191054.va6y2l5lyhyoo5p4@arbad (mailing list archive)
State New, archived
Headers show
Series add Maxbotix ultrasonic iio sensors with gpio bitbanging | expand

Commit Message

Andreas Klinger April 9, 2019, 7:10 p.m. UTC 
add compatibles for Maxbotix ultrasonic iio sensor types to yaml
documentation

Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
 .../bindings/iio/proximity/devantech-srf04.yaml    | 25 ++++++++++++++--------
 1 file changed, 16 insertions(+), 9 deletions(-)

Comments

Rob Herring April 9, 2019, 9:08 p.m. UTC | #1 
On Tue, Apr 9, 2019 at 2:11 PM Andreas Klinger <ak@it-klinger.de> wrote:
>
> add compatibles for Maxbotix ultrasonic iio sensor types to yaml
> documentation
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
>  .../bindings/iio/proximity/devantech-srf04.yaml    | 25 ++++++++++++++--------
>  1 file changed, 16 insertions(+), 9 deletions(-)

In the future, 'dt-bindings: iio: ...' for the subject please.

Reviewed-by: Rob Herring <robh@kernel.org>
Jonathan Cameron April 14, 2019, 1:08 p.m. UTC | #2 
On Tue, 9 Apr 2019 16:08:02 -0500
Rob Herring <robh+dt@kernel.org> wrote:

> On Tue, Apr 9, 2019 at 2:11 PM Andreas Klinger <ak@it-klinger.de> wrote:
> >
> > add compatibles for Maxbotix ultrasonic iio sensor types to yaml
> > documentation
> >
> > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> > ---
> >  .../bindings/iio/proximity/devantech-srf04.yaml    | 25 ++++++++++++++--------
> >  1 file changed, 16 insertions(+), 9 deletions(-)  
> 
> In the future, 'dt-bindings: iio: ...' for the subject please.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied and subject tidied up.

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
index e7aab785c97d..4e80ea7c1475 100644
--- a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/iio/proximity/devantech-srf04.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Devantech SRF04 ultrasonic range finder
+title: Devantech SRF04 and Maxbotix mb1000 ultrasonic range finder
 
 maintainers:
   - Andreas Klinger <ak@it-klinger.de>
@@ -16,19 +16,28 @@  description: |
   - echo-gpio is held high by the sensor after sending ultrasonic burst
     until it is received once again
 
-  Specifications about the driver can be found at:
+  Specifications about the devices can be found at:
   http://www.robot-electronics.co.uk/htm/srf04tech.htm
 
+  http://www.maxbotix.com/documents/LV-MaxSonar-EZ_Datasheet.pdf
+
 properties:
   compatible:
-    items:
-      - const: devantech,srf04
+    enum:
+      - devantech,srf04
+      - maxbotix,mb1000
+      - maxbotix,mb1010
+      - maxbotix,mb1020
+      - maxbotix,mb1030
+      - maxbotix,mb1040
 
   trig-gpios:
     description:
-      Definition of the GPIO for the triggering (output) This GPIO is set
-      for about 10 us by the driver to tell the device it should initiate
-      the measurement cycle.
+      Definition of the GPIO for the triggering (output)
+      This GPIO is set for about 10 us by the driver to tell the device it
+      should initiate the measurement cycle.
+      See Documentation/devicetree/bindings/gpio/gpio.txt for information
+      on how to specify a consumer gpio.
     maxItems: 1
 
   echo-gpios:
@@ -40,8 +49,6 @@  properties:
       trip.
       It needs to be an GPIO which is able to deliver an interrupt because
       the time between two interrupts is measured in the driver.
-      See Documentation/devicetree/bindings/gpio/gpio.txt for information
-      on how to specify a consumer gpio.
     maxItems: 1
 
 required: