[V3] ASoC: fsl_esai: Fix missing break in switch statement
diff mbox series

Message ID f1b910498324783f39b66a229c4abb80738097de.1554951087.git.shengjiu.wang@nxp.com
State New
Headers show
Series
  • [V3] ASoC: fsl_esai: Fix missing break in switch statement
Related show

Commit Message

Shengjiu Wang April 11, 2019, 2:53 a.m. UTC
case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be
independent of each other, so replace fall-through with break.

Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: <stable@vger.kernel.org>
---
changes in v3
- add cc stable
- change the subject

 sound/soc/fsl/fsl_esai.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shengjiu Wang April 11, 2019, 3:01 a.m. UTC | #1
Hi
> 
> 
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent
> of each other, so replace fall-through with break.
> 
> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Cc: <stable@vger.kernel.org>

Forget to add Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> , will send v4, sorry.

> ---
> changes in v3
> - add cc stable
> - change the subject
> 
>  sound/soc/fsl/fsl_esai.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index
> 3623aa9a6f2e..15202a637197 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai
> *dai, int clk_id,
>                 break;
>         case ESAI_HCKT_EXTAL:
>                 ecr |= ESAI_ECR_ETI;
> -               /* fall through */
> +               break;
>         case ESAI_HCKR_EXTAL:
>                 ecr |= ESAI_ECR_ERI;
>                 break;
> --

Patch
diff mbox series

diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index 3623aa9a6f2e..15202a637197 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -251,7 +251,7 @@  static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
 		break;
 	case ESAI_HCKT_EXTAL:
 		ecr |= ESAI_ECR_ETI;
-		/* fall through */
+		break;
 	case ESAI_HCKR_EXTAL:
 		ecr |= ESAI_ECR_ERI;
 		break;