[PULL,1/1] configure: Relax check for libseccomp

Commit Message

Eduardo Otubo April 12, 2019, 11:37 a.m. UTC

From: Helge Deller <[e-mail]>

All major distributions do support libseccomp version >= 2.3.0, so there
is no need to special-case on various architectures any longer.

Signed-off-by: Helge Deller <[e-mail]>
Reviewed-by: Daniel P. Berrangé <[e-mail]>
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
Acked-by: Eduardo Otubo <[e-mail]>
---
 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

Comments

Daniel P. Berrangé April 12, 2019, 11:43 a.m. UTC | #1

On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> From: Helge Deller <[e-mail]>
> 
> All major distributions do support libseccomp version >= 2.3.0, so there
> is no need to special-case on various architectures any longer.
> 
> Signed-off-by: Helge Deller <[e-mail]>
> Reviewed-by: Daniel P. Berrangé <[e-mail]>
> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
> Acked-by: Eduardo Otubo <[e-mail]>

When sending pull requests the subsystem maintainer *must*
add their Signed-off-by as this is what has legal meaning
with respect to the developer certificate of origin.

Acked-by is something that is used to give a different
subsystem maintainer permission to merge a patch that
would normally be your responsibility.


Regards,
Daniel

Eduardo Otubo April 12, 2019, 12:52 p.m. UTC | #2

On 12/04/2019 - 12:43:07, Daniel P. Berrange wrote:
> On Fri, Apr 12, 2019 at 01:37:30PM +0200, Eduardo Otubo wrote:
> > From: Helge Deller <[e-mail]>
> > 
> > All major distributions do support libseccomp version >= 2.3.0, so there
> > is no need to special-case on various architectures any longer.
> > 
> > Signed-off-by: Helge Deller <[e-mail]>
> > Reviewed-by: Daniel P. Berrangé <[e-mail]>
> > Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
> > Acked-by: Eduardo Otubo <[e-mail]>
> 
> When sending pull requests the subsystem maintainer *must*
> add their Signed-off-by as this is what has legal meaning
> with respect to the developer certificate of origin.
> 
> Acked-by is something that is used to give a different
> subsystem maintainer permission to merge a patch that
> would normally be your responsibility.
> 
> 

I think this issue was already raised by Peter on my last pull-request. My
appologies, I fixed the last pull request my didn't fix my script :/

Will send again after the release.
Thanks for pointing that out.

Patch

diff --git a/configure b/configure
index 1c563a7027..fcc56aa979 100755
--- a/configure
+++ b/configure
@@ -2377,36 +2377,16 @@  fi
 ##########################################
 # libseccomp check
 
-libseccomp_minver="2.2.0"
 if test "$seccomp" != "no" ; then
-    case "$cpu" in
-    i386|x86_64|mips)
-        ;;
-    arm|aarch64)
-        libseccomp_minver="2.2.3"
-        ;;
-    ppc|ppc64|s390x)
-        libseccomp_minver="2.3.0"
-        ;;
-    *)
-        libseccomp_minver=""
-        ;;
-    esac
-
-    if test "$libseccomp_minver" != "" &&
-       $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
+    libseccomp_minver="2.3.0"
+    if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
         seccomp_cflags="$($pkg_config --cflags libseccomp)"
         seccomp_libs="$($pkg_config --libs libseccomp)"
         seccomp="yes"
     else
         if test "$seccomp" = "yes" ; then
-            if test "$libseccomp_minver" != "" ; then
-                feature_not_found "libseccomp" \
-                    "Install libseccomp devel >= $libseccomp_minver"
-            else
-                feature_not_found "libseccomp" \
-                    "libseccomp is not supported for host cpu $cpu"
-            fi
+            feature_not_found "libseccomp" \
+                 "Install libseccomp devel >= $libseccomp_minver"
         fi
         seccomp="no"
     fi