ASoC: rockchip: Select DMA_PL330 by RK3399 audio
diff mbox series

Message ID 20190414210212.2144-1-alyssa@rosenzweig.io
State New
Headers show
Series
  • ASoC: rockchip: Select DMA_PL330 by RK3399 audio
Related show

Commit Message

Alyssa Rosenzweig April 14, 2019, 9:02 p.m. UTC
Without the appropriate DMA controller selected, the RK3399 audio
drivers compile but fail immediately. Accordingly, selecting the RK3399
audio without the corresponding PL330 controller is an invalid
configuration. Prevent errors (otherwise forcing the driver to unload at
runtime)  by an appropriate `select` directive in the Kconfig.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
---
 sound/soc/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Alyssa Rosenzweig April 16, 2019, 4:34 p.m. UTC | #1
Independent of this, should PL330 be selecting AMBA then?

Patch
diff mbox series

diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
index 957046ac6c8c..fa3cab461a60 100644
--- a/sound/soc/rockchip/Kconfig
+++ b/sound/soc/rockchip/Kconfig
@@ -73,6 +73,7 @@  config SND_SOC_RK3399_GRU_SOUND
 	select SND_SOC_RT5514_SPI
 	select SND_SOC_HDMI_CODEC
 	select SND_SOC_DMIC
+	select PL330_DMA
 	help
 	  Say Y or M here if you want to add support multiple codecs for SoC
 	  audio on Rockchip RK3399 GRU boards.