| Message ID | 20190415145505.18397-5-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | NVIDIA Tegra devfreq improvements and Tegra20/30 support | expand |
Hi, On 19. 4. 15. 오후 11:54, Dmitry Osipenko wrote: > There is no real benefit from doing so, hence let's drop that rate setting > for consistency. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra-devfreq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 69581c9082d4..d62fb1b0d9bb 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -648,8 +648,6 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > return PTR_ERR(tegra->emc_clock); > } > > - clk_set_rate(tegra->emc_clock, ULONG_MAX); > - It seems like that initialize the emc_clock as the supported maximum clock. But, if the rate for emc_clock initialized by either bootloader or clock driver and it's well working until this code, actually, it is not necessary. Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > tegra->rate_change_nb.notifier_call = tegra_actmon_rate_notify_cb; > err = clk_notifier_register(tegra->emc_clock, &tegra->rate_change_nb); > if (err) { >
16.04.2019 4:59, Chanwoo Choi пишет: > Hi, > > On 19. 4. 15. 오후 11:54, Dmitry Osipenko wrote: >> There is no real benefit from doing so, hence let's drop that rate setting >> for consistency. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> drivers/devfreq/tegra-devfreq.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index 69581c9082d4..d62fb1b0d9bb 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -648,8 +648,6 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> return PTR_ERR(tegra->emc_clock); >> } >> >> - clk_set_rate(tegra->emc_clock, ULONG_MAX); >> - > > It seems like that initialize the emc_clock as the supported maximum clock. > But, if the rate for emc_clock initialized by either bootloader or clock driver > and it's well working until this code, actually, it is not necessary. > > Looks good to me. > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> EMC clock rate is set properly at a boot time on all Tegra's, thanks.
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 69581c9082d4..d62fb1b0d9bb 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -648,8 +648,6 @@ static int tegra_devfreq_probe(struct platform_device *pdev) return PTR_ERR(tegra->emc_clock); } - clk_set_rate(tegra->emc_clock, ULONG_MAX); - tegra->rate_change_nb.notifier_call = tegra_actmon_rate_notify_cb; err = clk_notifier_register(tegra->emc_clock, &tegra->rate_change_nb); if (err) {
There is no real benefit from doing so, hence let's drop that rate setting for consistency. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra-devfreq.c | 2 -- 1 file changed, 2 deletions(-)