| Message ID | jpgwojv9pwv.fsf@linux.bootlegged.copy (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb-mtp: change default to success for usb_mtp_update_object | expand |
Forgot to cc people ... Bandan Das <bsd@redhat.com> writes: > Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat > failure) checks if lstat succeeded when updating attributes of a > file. However, it also changed behavior to return an error by > default. This is incorrect because for smaller file sizes, Qemu > will attempt to write the file in one go and there won't be > an object for it. > > Fixes: c5ead51f90cf > Signed-off-by: Bandan Das <bsd@redhat.com> > --- > hw/usb/dev-mtp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index ebf210fbf8..5de22738ce 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -1587,7 +1587,7 @@ done: > > static int usb_mtp_update_object(MTPObject *parent, char *name) > { > - int ret = -1; > + int ret = 0; > > MTPObject *o = > usb_mtp_object_lookup_name(parent, name, strlen(name));
On Mon, Apr 15, 2019 at 12:50:43PM -0400, Bandan Das wrote: > Forgot to cc people ... > > Bandan Das <bsd@redhat.com> writes: > > > Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat > > failure) checks if lstat succeeded when updating attributes of a > > file. However, it also changed behavior to return an error by > > default. This is incorrect because for smaller file sizes, Qemu > > will attempt to write the file in one go and there won't be > > an object for it. Patch added to usb queue. Current queue is https://git.kraxel.org/cgit/qemu/log/?h=queue/usb If anything is missing there please resend. thanks, Gerd
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index ebf210fbf8..5de22738ce 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1587,7 +1587,7 @@ done: static int usb_mtp_update_object(MTPObject *parent, char *name) { - int ret = -1; + int ret = 0; MTPObject *o = usb_mtp_object_lookup_name(parent, name, strlen(name));
Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat failure) checks if lstat succeeded when updating attributes of a file. However, it also changed behavior to return an error by default. This is incorrect because for smaller file sizes, Qemu will attempt to write the file in one go and there won't be an object for it. Fixes: c5ead51f90cf Signed-off-by: Bandan Das <bsd@redhat.com> --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)