[v4,2/2] trace-cmd: Document record --no-filter option in record's man page
diff mbox series

Message ID 20190417130959.10064-3-kaslevs@vmware.com
State Accepted
Headers show
Series
  • Optimize pid filters
Related show

Commit Message

Slavomir Kaslev April 17, 2019, 1:09 p.m. UTC
Add a section about the new --no-filter argument of `trace-cmd record`
to its man page.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
 Documentation/trace-cmd-record.1.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Phil Auld April 17, 2019, 2:05 p.m. UTC | #1
On Wed, Apr 17, 2019 at 04:09:59PM +0300 Slavomir Kaslev wrote:
> Add a section about the new --no-filter argument of `trace-cmd record`
> to its man page.
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
> ---
>  Documentation/trace-cmd-record.1.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt
> index 68afa16..b230aa8 100644
> --- a/Documentation/trace-cmd-record.1.txt
> +++ b/Documentation/trace-cmd-record.1.txt
> @@ -83,6 +83,10 @@ OPTIONS
>  
>      The above are usually safe to use to compare fields.
>  
> +*--no-filter*::
> +    Do not set any event filters, including the default one which ignores events
> +    caused by trace-cmd itself.
> +
>  *-R* 'trigger'::
>      Specify a trigger for the previous event. This must come after a *-e*. 
>      This will add a given trigger to the given event. To only enable the trigger
> -- 
> 2.19.1
> 

Acked-by: Phil Auld <pauld@redhat.com>

and/or

Tested-by: Phil Auld <pauld@redhat.com>




Cheers,
Phil


--
Steven Rostedt April 17, 2019, 4:19 p.m. UTC | #2
On Wed, 17 Apr 2019 16:09:59 +0300
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> Add a section about the new --no-filter argument of `trace-cmd record`
> to its man page.
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
> ---
>  Documentation/trace-cmd-record.1.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt
> index 68afa16..b230aa8 100644
> --- a/Documentation/trace-cmd-record.1.txt
> +++ b/Documentation/trace-cmd-record.1.txt
> @@ -83,6 +83,10 @@ OPTIONS
>  
>      The above are usually safe to use to compare fields.
>  
> +*--no-filter*::
> +    Do not set any event filters, including the default one which ignores events
> +    caused by trace-cmd itself.

Actually, this is wrong and so is the help message.

It should be:

  *--no-filter*::
	Do not filter out the trace-cmd threads. By default, the
	threads are filtered out to not be traced by events. This
	option will have the trace-cmd threads also be traced.

And the help message should be:

 # trace-cmd record -h
  [..]
  --no-filter include trace-cmd threads in the trace

Want to resend this patch and also fix the help message (assume it is
applied).

Thanks!

-- Steve

> +
>  *-R* 'trigger'::
>      Specify a trigger for the previous event. This must come after a *-e*. 
>      This will add a given trigger to the given event. To only enable the trigger
Steven Rostedt April 17, 2019, 4:24 p.m. UTC | #3
On Wed, 17 Apr 2019 12:19:08 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Actually, this is wrong and so is the help message.
> 
> It should be:
> 
>   *--no-filter*::
> 	Do not filter out the trace-cmd threads. By default, the
> 	threads are filtered out to not be traced by events. This
> 	option will have the trace-cmd threads also be traced.
> 
> And the help message should be:
> 
>  # trace-cmd record -h
>   [..]
>   --no-filter include trace-cmd threads in the trace
> 
> Want to resend this patch and also fix the help message (assume it is
> applied).


Actually, I just pushed an update to upstream. Could you just combine
this and the --no-filter patch, and update both help messages.

That is, I didn't apply the --no-filter patch.

Thanks!

-- Steve

Patch
diff mbox series

diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt
index 68afa16..b230aa8 100644
--- a/Documentation/trace-cmd-record.1.txt
+++ b/Documentation/trace-cmd-record.1.txt
@@ -83,6 +83,10 @@  OPTIONS
 
     The above are usually safe to use to compare fields.
 
+*--no-filter*::
+    Do not set any event filters, including the default one which ignores events
+    caused by trace-cmd itself.
+
 *-R* 'trigger'::
     Specify a trigger for the previous event. This must come after a *-e*. 
     This will add a given trigger to the given event. To only enable the trigger