From patchwork Wed Apr 17 19:15:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 10906013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9FBEC14DB for ; Wed, 17 Apr 2019 19:15:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84D3428ADC for ; Wed, 17 Apr 2019 19:15:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 795AD28A96; Wed, 17 Apr 2019 19:15:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3A5F728AFF for ; Wed, 17 Apr 2019 19:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=07QHKT6Ro1hHW0tJBXZAhQA7BKrfQ8c/GqZ3eBmXoK4=; b=uSNh5Mui488A+E jLUTH7n7i6VqhIy4IWOWWLexvJJ01MyfFi93TCn/dBge7D7RXFYDpEpmVTRCCiobbT7Xz0U6VkADc 6JFpbnIFUA4RBysxBjDvVGCeIAqkzegZxP98TDK3+cMgGocSSHXhm+F3X3wFXBDuEkGtjBqk8Mdq0 ChtygFNbvM/kRYB74OdZsYnrqf/+yAx6ntG4FHMGtKFHEG+195ckKByRrKfMOTIqB3hK8RLcponYP pVIQidy0qcQBDC56JCWBfHMElgHYfmic2Ow/FhUFm3dlDQokdej7YsfIZhYj4cd5f40gGar7pCGMF MRsjAiYNHX7yckjuKnMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGq20-0007Ta-Tx; Wed, 17 Apr 2019 19:15:40 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGq1q-0007Ft-S3 for ath10k@lists.infradead.org; Wed, 17 Apr 2019 19:15:32 +0000 Received: by mail-lf1-x141.google.com with SMTP id w23so19690982lfc.9 for ; Wed, 17 Apr 2019 12:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yZlYdkbsnuWRekasQAPicgHhW2O1in5TKogUwhEyeAY=; b=FUnjRqLAipT9GC80FeDYkIRkseovEPOjV56eFccMEEMB+GDfG9VdpNpCIGdH/bTFgi 8FzlrnAKp2/ST3mEAY5wCTwGMR4GuP9qjVts6Ik+/ngMv9Nlvmq9KGnHPGrR53S92bk1 HMK+q4UI7uTbn4SdtKtJZ+SXV5NXP0VsRRNGWLQOgws1wgR35bdezlnNrDAji+NykDF4 UqKauuD3c7GJuD7hhOq7UBqsK8kiYzCXOp6J45w8YdWu9hLR1fVKLA8KaATNqkEBrwlY SmpVd2SGCS2H+5i/eKK9T7RPLyKm6EvdkvZoSZQFNEEU0WhCKfl3bVth6YdBAUz9jegR eygQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yZlYdkbsnuWRekasQAPicgHhW2O1in5TKogUwhEyeAY=; b=RylfRlAGHy5FaUeRi6hWVjVxSH33ZzvijzLL9mj94ytkLHfk4vyVLgUBseRMPoKZfN Xed8m37CF1sy42GWoGa+bsUlMWSy+yieIOnZcXypWxEwh2vr0PUgp/N1wYtM6JJIM9hz mXUpophcZoFeF7dYWW2L+yfiVJZ4hNrqpJIb6dsVkEboL6vL4IWRgpRL3fTppxtTOfTl ZkNY/f3LA0o0iexZPj10FTDtoIQESu93WZc6nIIRM33Wr4VIQJQvs/zxba0ArsfK0twx uVo8j8+OElzgQ+jqeLQYMN4RTTGrzDXBEqE9sngeW4cwh6VAe5iG7oTltUPMmtSkRplQ 7sZA== X-Gm-Message-State: APjAAAUS6Airp9xa9O+LHDBDimSCNmnRHSqzrOJwhVXtfURGMkKnCTGB HoL/yP1Q8+GgtQWNNymqwfc= X-Google-Smtp-Source: APXvYqw1rKENYOyuvxq1zMqprYZEcR4yonZJjzg6pue8q26TahnEg2jB1QPrP+JgNrBT0M8A/vLu9Q== X-Received: by 2002:ac2:4551:: with SMTP id j17mr19496154lfm.141.1555528529381; Wed, 17 Apr 2019 12:15:29 -0700 (PDT) Received: from localhost.localdomain (81-233-89-221-no75.tbcn.telia.com. [81.233.89.221]) by smtp.gmail.com with ESMTPSA id j27sm11387203lfk.97.2019.04.17.12.15.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 12:15:28 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2 4/5] ath10k: sdio: add missing error check Date: Wed, 17 Apr 2019 21:15:02 +0200 Message-Id: <20190417191503.18814-5-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190417191503.18814-1-erik.stromdahl@gmail.com> References: <20190417191503.18814-1-erik.stromdahl@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_121530_903527_86F98C12 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Stromdahl Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Although not likely, the bundle allocation might fail. Add proper error check and warning print. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/sdio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index b89732aad97c..b8b3059721ee 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -586,6 +586,11 @@ static int ath10k_sdio_mbox_rx_alloc(struct ath10k *ar, act_len, &bndl_cnt); + if (ret) { + ath10k_warn(ar, "alloc_bundle error %d\n", ret); + goto err; + } + n_lookaheads += bndl_cnt; i += bndl_cnt; /*Next buffer will be the last in the bundle */