| Message ID | 20190418150740.24250-1-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: VMX: Include architectural defs header in capabilities.h | expand |
On 18/04/19 17:07, Sean Christopherson wrote: > The capabilities header depends on asm/vmx.h but doesn't explicitly > include said file. This currently doesn't cause problems as all users > of capbilities.h first include asm/vmx.h, but the issue often results in > build errors if someone starts moving things around the VMX files. > > Fixes: 3077c1910882 ("KVM: VMX: Move capabilities structs and helpers to dedicated file") > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > arch/x86/kvm/vmx/capabilities.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kvm/vmx/capabilities.h b/arch/x86/kvm/vmx/capabilities.h > index 854e144131c6..d6664ee3d127 100644 > --- a/arch/x86/kvm/vmx/capabilities.h > +++ b/arch/x86/kvm/vmx/capabilities.h > @@ -2,6 +2,8 @@ > #ifndef __KVM_X86_VMX_CAPS_H > #define __KVM_X86_VMX_CAPS_H > > +#include <asm/vmx.h> > + > #include "lapic.h" > > extern bool __read_mostly enable_vpid; > Queued. Paolo
diff --git a/arch/x86/kvm/vmx/capabilities.h b/arch/x86/kvm/vmx/capabilities.h index 854e144131c6..d6664ee3d127 100644 --- a/arch/x86/kvm/vmx/capabilities.h +++ b/arch/x86/kvm/vmx/capabilities.h @@ -2,6 +2,8 @@ #ifndef __KVM_X86_VMX_CAPS_H #define __KVM_X86_VMX_CAPS_H +#include <asm/vmx.h> + #include "lapic.h" extern bool __read_mostly enable_vpid;
The capabilities header depends on asm/vmx.h but doesn't explicitly include said file. This currently doesn't cause problems as all users of capbilities.h first include asm/vmx.h, but the issue often results in build errors if someone starts moving things around the VMX files. Fixes: 3077c1910882 ("KVM: VMX: Move capabilities structs and helpers to dedicated file") Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- arch/x86/kvm/vmx/capabilities.h | 2 ++ 1 file changed, 2 insertions(+)