diff mbox series

[v2,2/2] dt-bindings: iio: tsl2583: convert bindings to YAML format

Message ID 20190424092238.6381-2-masneyb@onstation.org (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] dt-bindings: iio: tsl2772: convert bindings to YAML format | expand

Commit Message

Brian Masney April 24, 2019, 9:22 a.m. UTC
Convert the tsl2583 device tree bindings to the new YAML format.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
Changes since v1:
- Dropped description from reg and interrupts properties.
- Dropped $ref from vcc-supply property.
- Changed 'tsl2581@29' in example to 'als-sensor@29'

I can no longer find the data sheet for this device linked on AMS's
site. The datasheet is still on Digikey [1], however I didn't include it
in the binding document since I assume that we should only link to the
manufacturer's website.
https://media.digikey.com/pdf/Data%20Sheets/Austriamicrosystems%20PDFs/TSL2581,83.pdf

 .../devicetree/bindings/iio/light/tsl2583.txt | 25 ----------
 .../bindings/iio/light/tsl2583.yaml           | 46 +++++++++++++++++++
 2 files changed, 46 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/light/tsl2583.txt
 create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2583.yaml

Comments

Rob Herring April 24, 2019, 4 p.m. UTC | #1
On Wed, Apr 24, 2019 at 4:22 AM Brian Masney <masneyb@onstation.org> wrote:
>
> Convert the tsl2583 device tree bindings to the new YAML format.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> Changes since v1:
> - Dropped description from reg and interrupts properties.
> - Dropped $ref from vcc-supply property.
> - Changed 'tsl2581@29' in example to 'als-sensor@29'
>
> I can no longer find the data sheet for this device linked on AMS's
> site. The datasheet is still on Digikey [1], however I didn't include it
> in the binding document since I assume that we should only link to the
> manufacturer's website.
> https://media.digikey.com/pdf/Data%20Sheets/Austriamicrosystems%20PDFs/TSL2581,83.pdf
>
>  .../devicetree/bindings/iio/light/tsl2583.txt | 25 ----------
>  .../bindings/iio/light/tsl2583.yaml           | 46 +++++++++++++++++++
>  2 files changed, 46 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/iio/light/tsl2583.txt
>  create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2583.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2583.txt b/Documentation/devicetree/bindings/iio/light/tsl2583.txt
> deleted file mode 100644
> index 059dffa1829a..000000000000
> --- a/Documentation/devicetree/bindings/iio/light/tsl2583.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -* TAOS TSL 2580/2581/2583 ALS sensor
> -
> -Required properties:
> -
> -  - compatible: Should be one of
> -               "amstaos,tsl2580"
> -               "amstaos,tsl2581"
> -               "amstaos,tsl2583"
> -  - reg: the I2C address of the device
> -
> -Optional properties:
> -
> -  - interrupts: the sole interrupt generated by the device
> -
> -  Refer to interrupt-controller/interrupts.txt for generic interrupt client
> -  node bindings.
> -
> -  - vcc-supply: phandle to the regulator that provides power to the sensor.
> -
> -Example:
> -
> -tsl2581@29 {
> -       compatible = "amstaos,tsl2581";
> -       reg = <0x29>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2583.yaml b/Documentation/devicetree/bindings/iio/light/tsl2583.yaml
> new file mode 100644
> index 000000000000..6989a8a54c5c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/tsl2583.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/tsl2583.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMS/TAOS Ambient Light Sensor (ALS)
> +
> +maintainers:
> +  - Brian Masney <masneyb@onstation.org>
> +
> +description: |
> +  Ambient light sensing with an i2c interface.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - amstaos,tsl2580
> +      - amstaos,tsl2581
> +      - amstaos,tsl2583
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vcc-supply:
> +    description: Regulator that provides power to the sensor
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        als-sensor@29 {

light-sensor@29

With that,

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/light/tsl2583.txt b/Documentation/devicetree/bindings/iio/light/tsl2583.txt
deleted file mode 100644
index 059dffa1829a..000000000000
--- a/Documentation/devicetree/bindings/iio/light/tsl2583.txt
+++ /dev/null
@@ -1,25 +0,0 @@ 
-* TAOS TSL 2580/2581/2583 ALS sensor
-
-Required properties:
-
-  - compatible: Should be one of
-		"amstaos,tsl2580"
-		"amstaos,tsl2581"
-		"amstaos,tsl2583"
-  - reg: the I2C address of the device
-
-Optional properties:
-
-  - interrupts: the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic interrupt client
-  node bindings.
-
-  - vcc-supply: phandle to the regulator that provides power to the sensor.
-
-Example:
-
-tsl2581@29 {
-	compatible = "amstaos,tsl2581";
-	reg = <0x29>;
-};
diff --git a/Documentation/devicetree/bindings/iio/light/tsl2583.yaml b/Documentation/devicetree/bindings/iio/light/tsl2583.yaml
new file mode 100644
index 000000000000..6989a8a54c5c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/tsl2583.yaml
@@ -0,0 +1,46 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/tsl2583.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AMS/TAOS Ambient Light Sensor (ALS)
+
+maintainers:
+  - Brian Masney <masneyb@onstation.org>
+
+description: |
+  Ambient light sensing with an i2c interface.
+
+properties:
+  compatible:
+    enum:
+      - amstaos,tsl2580
+      - amstaos,tsl2581
+      - amstaos,tsl2583
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  vcc-supply:
+    description: Regulator that provides power to the sensor
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        als-sensor@29 {
+                compatible = "amstaos,tsl2581";
+                reg = <0x29>;
+        };
+    };
+...